Issue 3511043: code review 3511043: runtime/cgo: take 2

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3511043: code review 3511043: runtime/cgo: take 2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by rsc

Modified:
14 years, 5 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

runtime/cgo: take 2 This is a second attempt at submitting http://codereview.appspot.com/3420043 A Mercurial problem lost the new files in that submit.

Patch Set 1 #

Patch Set 2 : code review 3511043: runtime/cgo: take 2 #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+705 lines, -0 lines)			Patch
A	src/pkg/runtime/cgo/386.S	View	1 chunk	+67 lines, -0 lines	0 comments	Download
A	src/pkg/runtime/cgo/Makefile	View	1 chunk	+35 lines, -0 lines	0 comments	Download
A	src/pkg/runtime/cgo/amd64.S	View	1 chunk	+73 lines, -0 lines	0 comments	Download
A	src/pkg/runtime/cgo/cgo.go	View	1 chunk	+10 lines, -0 lines	0 comments	Download
A	src/pkg/runtime/cgo/darwin_386.c	View	1 chunk	+144 lines, -0 lines	0 comments	Download
A	src/pkg/runtime/cgo/darwin_amd64.c	View	1 chunk	+125 lines, -0 lines	0 comments	Download
A	src/pkg/runtime/cgo/iscgo.c	View	1 chunk	+14 lines, -0 lines	0 comments	Download
A	src/pkg/runtime/cgo/libcgo.h	View	1 chunk	+60 lines, -0 lines	0 comments	Download
A	src/pkg/runtime/cgo/linux_386.c	View	1 chunk	+68 lines, -0 lines	0 comments	Download
A	src/pkg/runtime/cgo/linux_amd64.c	View	1 chunk	+58 lines, -0 lines	0 comments	Download
A	src/pkg/runtime/cgo/util.c	View	1 chunk	+51 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 5 months ago (2010-12-08 19:09:59 UTC) #1

rsc

*** Submitted as c4d9b682a247 *** runtime/cgo: take 2 This is a second attempt at submitting ...

14 years, 5 months ago (2010-12-08 19:10:01 UTC) #2

LGTM

Expand All Messages | Collapse All Messages