Issue 3510041: code review 3510041: godoc: use file instead of file set for computing line info

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3510041: code review 3510041: godoc: use file instead of file set for computing line info (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 7 months ago by gri

Modified:
14 years, 7 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

godoc: use file instead of file set for computing line info Reduces indexing time by ~10%; from ~44s to ~39s, best of 3 runs.

Patch Set 2 : code review 3510041: godoc: use file instead of file set for computing line info #

Patch Set 3 : code review 3510041: godoc: use file instead of file set for computing line info #

Total comments: 1

Created: 14 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	src/cmd/godoc/index.go	View	1	4 chunks	+5 lines, -2 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 7 months ago (2010-12-08 00:08:42 UTC) #1

rsc1

LGTM http://codereview.appspot.com/3510041/diff/5001/src/cmd/godoc/index.go File src/cmd/godoc/index.go (right): http://codereview.appspot.com/3510041/diff/5001/src/cmd/godoc/index.go#newcode435 src/cmd/godoc/index.go:435: last *token.File // last file added to file ...

14 years, 7 months ago (2010-12-08 01:21:10 UTC) #2

gri

On Tue, Dec 7, 2010 at 5:21 PM, <rsc@google.com> wrote: > LGTM > > > ...

14 years, 7 months ago (2010-12-08 05:53:38 UTC) #3

gri

14 years, 7 months ago (2010-12-08 05:55:34 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=babf712fa176 ***

godoc: use file instead of file set for computing line info

Reduces indexing time by ~10%; from ~44s to ~39s, best of 3 runs.

R=rsc
CC=golang-dev
http://codereview.appspot.com/3510041

Committer: Robert Griesemer <gri@golang.org>

Expand All Messages | Collapse All Messages