Context management for subprocess.Popen (Python #10554)

[merwok, 2010-12-03 01:57:07]

Two details and one question.

http://codereview.appspot.com/3441041/diff/1/Doc/library/subprocess.rst
File Doc/library/subprocess.rst (right):

http://codereview.appspot.com/3441041/diff/1/Doc/library/subprocess.rst#newco...
Doc/library/subprocess.rst:214: with Popen([sys.executable, "-c", "import
sys;sys.stdout.write('hello')"], stdout=PIPE) as proc:
Maybe a simpler example would be as good and less noisy:

"-c", "print('hello,')"

http://codereview.appspot.com/3441041/diff/1/Lib/subprocess.py
File Lib/subprocess.py (right):

http://codereview.appspot.com/3441041/diff/1/Lib/subprocess.py#newcode709
Lib/subprocess.py:709: self.stdin.close()
There is some other cleanup done in __del__; I don’t know if it should be done
in __exit__ too.

(Implementation detail: To not run it twice, it would be factored out in another
method, called from __exit__ and from __del__ (if not already called))

http://codereview.appspot.com/3441041/diff/1/Lib/test/test_subprocess.py
File Lib/test/test_subprocess.py (right):

http://codereview.appspot.com/3441041/diff/1/Lib/test/test_subprocess.py#newc...
Lib/test/test_subprocess.py:1236: ContextManagerTests)
Maybe it’s the opportunity to use this diff-friendly idiom:

CommandsWithSpaces,
ContextManagerTests,
)