Issue 3418041: code review 3418041: throughout: replace bytes.Add and bytes.AddByte with ca...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3418041: code review 3418041: throughout: replace bytes.Add and bytes.AddByte with ca... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by r

Modified:
14 years, 11 months ago

Reviewers:

CC:
gri, golang-dev

Visibility:
Public.

Description

throughout: replace bytes.Add and bytes.AddByte with calls to append

Patch Set 1 #

Patch Set 2 : code review 3418041: throughout: replace bytes.Add and bytes.AddByte with ca... #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -30 lines)			Patch
M	compiler/generator/generator.go	View	2 chunks	+5 lines, -9 lines	0 comments	Download
M	proto/decode.go	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	proto/encode.go	View	18 chunks	+17 lines, -18 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello gri (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 11 months ago (2010-12-02 18:34:04 UTC) #1

gri

LGTM - gri On Thu, Dec 2, 2010 at 10:34 AM, <r@golang.org> wrote: > Reviewers: ...

14 years, 11 months ago (2010-12-02 18:36:29 UTC) #2

14 years, 11 months ago (2010-12-02 18:39:44 UTC) #3

*** Submitted as
http://code.google.com/p/goprotobuf/source/detail?r=cd9820afcf35 ***

throughout: replace bytes.Add and bytes.AddByte with calls to append

R=gri
CC=golang-dev
http://codereview.appspot.com/3418041

Expand All Messages | Collapse All Messages