Issue 3396042: Doc: CG: clarify lily-git.tcl and git-cl.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3396042: Doc: CG: clarify lily-git.tcl and git-cl. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by Graham Percival (old account)

Modified:
13 years, 3 months ago

Reviewers:
Valentin Villenave, carl.d.sorensen

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Doc: CG: clarify lily-git.tcl and git-cl.

Patch Set 2 : CG: use out-of-tree building in main compiling chapter. #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -38 lines)			Patch
	M	Documentation/included/compile.itexi	View	1	7 chunks	+42 lines, -38 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Valentin Villenave

Hi Graham, LGTM as well. Just a few comments: http://codereview.appspot.com/3396042/diff/1/Documentation/contributor/source-code.itexi File Documentation/contributor/source-code.itexi (right): http://codereview.appspot.com/3396042/diff/1/Documentation/contributor/source-code.itexi#newcode143 Documentation/contributor/source-code.itexi:143: ...

13 years, 4 months ago (2010-12-06 23:12:09 UTC) #3

Graham Percival (old account)

13 years, 4 months ago (2010-12-07 17:27:17 UTC) #4

On 2010/12/06 23:12:09, Valentin Villenave wrote:
> Hi Graham,
> LGTM as well. Just a few comments:

Thanks, pushed.

> Documentation/contributor/source-code.itexi:143: @quotation
> Is there a rule for the use of @quotation? (I noticed there's another one in
> source-code.itexi.) If so, we probably should add it to the CG's Syntax
Survey.

No, but I don't think we need to mention it.  The CG is a special case; the
usual docs shouldn't use quotation.

> I wouldn't bother with the size limit, it's much less drastic on frogs@. What
I
> *would* mention, however, is to add [PATCH] in the email's subject.

Thanks, done.

> Documentation/contributor/source-code.itexi:1032: You must have a gmail
account.
> Are all Google accounts Gmail accounts? (I don't suppose it's owrth adding a
> @uref{https://www.google.com/accounts/NewAccount} link, is it?)

I don't know; I just left that part of the docs alone.  Once the current
discussion about virtualization dies down, I'll ask somebody to look into gmail
vs. google accounts.

>
http://codereview.appspot.com/3396042/diff/1/Documentation/contributor/source...
> Documentation/contributor/source-code.itexi:1051: answer with a newline (CR).
> How about "just hit Return"?

I think that "newline (CR)" is a bit more technical, so I left it as-is.  I'm
not particularly fussy about this, though.

Expand All Messages | Collapse All Messages