Issue 3337042: code review 3337042: Sync from internal version:

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3337042: code review 3337042: Sync from internal version: (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by dsymonds

Modified:
14 years, 11 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

Sync from internal version: - packed repeated field support - more useful ErrRequiredNotSet - decoding simplification using append

Patch Set 1 #

Patch Set 2 : code review 3337042: Sync from internal version: #

Patch Set 3 : code review 3337042: Sync from internal version: #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+406 lines, -121 lines)			Patch
M	compiler/generator/generator.go	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	compiler/testdata/test.proto	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	compiler/testdata/test.pb.go.golden	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	proto/all_test.go	View	8 chunks	+106 lines, -13 lines	0 comments	Download
M	proto/decode.go	View	11 chunks	+131 lines, -99 lines	0 comments	Download
M	proto/encode.go	View	5 chunks	+64 lines, -2 lines	0 comments	Download
M	proto/properties.go	View	7 chunks	+46 lines, -6 lines	0 comments	Download
M	proto/testdata/test.proto	View	2 chunks	+23 lines, -0 lines	0 comments	Download
M	proto/testdata/test.pb.go	View	2 chunks	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 11 months ago (2010-11-30 23:00:28 UTC) #1

dsymonds

14 years, 11 months ago (2010-11-30 23:09:33 UTC) #3

*** Submitted as 4ad998760947 ***

	Sync from internal version:
          - packed repeated field support
          - more useful ErrRequiredNotSet
          - decoding simplification using append

R=r
CC=golang-dev
http://codereview.appspot.com/3337042

Expand All Messages | Collapse All Messages