Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(34)

Issue 3337042: code review 3337042: Sync from internal version: (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 11 months ago by dsymonds
Modified:
14 years, 11 months ago
Reviewers:
CC:
r, golang-dev
Visibility:
Public.

Description

Sync from internal version: - packed repeated field support - more useful ErrRequiredNotSet - decoding simplification using append

Patch Set 1 #

Patch Set 2 : code review 3337042: Sync from internal version: #

Patch Set 3 : code review 3337042: Sync from internal version: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+406 lines, -121 lines) Patch
M compiler/generator/generator.go View 2 chunks +7 lines, -1 line 0 comments Download
M compiler/testdata/test.proto View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/testdata/test.pb.go.golden View 1 chunk +1 line, -0 lines 0 comments Download
M proto/all_test.go View 8 chunks +106 lines, -13 lines 0 comments Download
M proto/decode.go View 11 chunks +131 lines, -99 lines 0 comments Download
M proto/encode.go View 5 chunks +64 lines, -2 lines 0 comments Download
M proto/properties.go View 7 chunks +46 lines, -6 lines 0 comments Download
M proto/testdata/test.proto View 2 chunks +23 lines, -0 lines 0 comments Download
M proto/testdata/test.pb.go View 2 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 3
dsymonds
Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 11 months ago (2010-11-30 23:00:28 UTC) #1
r
LGTM
14 years, 11 months ago (2010-11-30 23:03:44 UTC) #2
dsymonds
14 years, 11 months ago (2010-11-30 23:09:33 UTC) #3
*** Submitted as 4ad998760947 ***

	Sync from internal version:
          - packed repeated field support
          - more useful ErrRequiredNotSet
          - decoding simplification using append

R=r
CC=golang-dev
http://codereview.appspot.com/3337042
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b