Fix #1427.

Fix #1427.

The copy constructor for Book assumes the list of objects to clone are
scores, which is unsafe since a \book(part) block can also contain markup and
page markers.

* lily/book.cc (copy constructor):

  treat entries in scores_ separately, cloning Score and Page_marker objects

* lily/include/page-marker.hh, lily/page-marker.cc:

  add copy constructor

[Reinhold, 2010-11-25 00:16:22]

I can't comment on the code itself (from a first look it makes sense, but I
haven't dug too deep). What is missing, though, is a regtest...

[Neil Puttock, 2010-11-25 00:21:21]

On 2010/11/25 00:16:22, Reinhold wrote:
> I can't comment on the code itself (from a first look it makes sense, but I
> haven't dug too deep). What is missing, though, is a regtest...

I've held off doing a regtest until somebody can confirm this is the right
course of action, though if you insist... :)

[Neil Puttock, 2010-11-25 00:32:58]

On 2010/11/25 00:21:21, Neil Puttock wrote:

> I've held off doing a regtest until somebody can confirm this is the right
> course of action, though if you insist... :)

OK, regtest's on hold while I work out why the following doesn't work:

mypart = \bookpart {
  \relative c' { c1 }
}

\book { \mypart }

(I assume it should :)

[Carl, 2010-12-04 00:48:09]

On 2010/11/25 00:32:58, Neil Puttock wrote:
> OK, regtest's on hold while I work out why the following doesn't work:
> 

The regtest runs with my proposed patch for issue 1428.

Thanks,

Carl

[Carl, 2010-12-07 03:43:01]

LGTM.

Do you think it's ready to go now?

[Neil Puttock, 2010-12-07 23:25:47]

On 2010/12/07 03:43:01, Carl wrote:
> LGTM.
> 
> Do you think it's ready to go now?

Sure.

Cheers,
Neil