Issue 3299041: code review 3299041: syscall: restrict access rights param of OpenProcess() ...

Issue 3299041: code review 3299041: syscall: restrict access rights param of OpenProcess() ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 7 months ago by brainman

Modified:
14 years, 7 months ago

Reviewers:

CC:
vcc, rsc, golang-dev

Visibility:
Public.

Description

syscall: restrict access rights param of OpenProcess() to the minimum needed Fixes issue 1270.

Patch Set 2 : code review 3299041: syscall: restrict access rights param of OpenProcess() ... #

Total comments: 2

Patch Set 3 : code review 3299041: syscall: restrict access rights param of OpenProcess() ... #

Created: 14 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -8 lines)			Patch
	M	src/pkg/syscall/syscall_windows.go	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
	M	src/pkg/syscall/ztypes_windows_386.go	View	1 2	2 chunks	+4 lines, -7 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change.

14 years, 7 months ago (2010-11-24 03:02:31 UTC) #1

vcc

http://codereview.appspot.com/3299041/diff/2001/src/pkg/syscall/syscall_windows.go File src/pkg/syscall/syscall_windows.go (right): http://codereview.appspot.com/3299041/diff/2001/src/pkg/syscall/syscall_windows.go#newcode732 src/pkg/syscall/syscall_windows.go:732: const da = STANDARD_RIGHTS_REQUIRED | PROCESS_QUERY_INFORMATION | SYNCHRONIZE STANDARD_RIGHTS_READ ...

14 years, 7 months ago (2010-11-24 04:37:55 UTC) #2

brainman

Thank you for review. http://codereview.appspot.com/3299041/diff/2001/src/pkg/syscall/syscall_windows.go File src/pkg/syscall/syscall_windows.go (right): http://codereview.appspot.com/3299041/diff/2001/src/pkg/syscall/syscall_windows.go#newcode732 src/pkg/syscall/syscall_windows.go:732: const da = STANDARD_RIGHTS_REQUIRED | ...

14 years, 7 months ago (2010-11-24 04:54:28 UTC) #3

brainman

Hello golang-dev@googlegroups.com, vcc (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 7 months ago (2010-11-24 04:54:38 UTC) #4

vcc

LGTM On 2010/11/24 04:54:38, brainman wrote: > Hello mailto:golang-dev@googlegroups.com, vcc (cc: mailto:golang-dev@googlegroups.com), > > Please ...

14 years, 7 months ago (2010-11-24 04:58:17 UTC) #5

brainman

14 years, 7 months ago (2010-12-08 05:20:39 UTC) #7

*** Submitted as http://code.google.com/p/go/source/detail?r=c05377b74dd9 ***

syscall: restrict access rights param of OpenProcess() to the minimum needed

Fixes issue 1270.

R=vcc, rsc
CC=golang-dev
http://codereview.appspot.com/3299041

Committer: Alex Brainman <alex.brainman@gmail.com>

Expand All Messages | Collapse All Messages