Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7278)

Issue 3212041: manual convert-ly: minimum-Y-extent (1298+1299). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by Graham Percival (old account)
Modified:
13 years, 5 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

manual convert-ly: minimum-Y-extent (1298+1299). Patch by Keith O'Hara. cary.ly used Y-extent to increase space for staves, use markup-system-spacing instead. orchestra.ly used Y-extent to created a custom context for rows rehearsal and tempo marks. The new way to creat such a row is to give the context a staff-affinity, and put the spacing requirements into nonstaff-unrelatedstaff-spacing, etc. This file also had its own definition of the \Dynamics context, which is now built-in. engravers-one-by-one.ly used Y-extent to enforce uniform spacing of staves, now done automatically. (also changed on the LSR) percussion.itely used Y-extent to produce a spacing to the lyrics line very similar to what we now get by default. spacing.itely used Y-extent among other \overrides in an example ancient.itely used Y-extent to make an invisible staff take up no space. The markup can stand alone with no staff. (If for some reason a @lilypond must contain notes or skips, then just delete the 2 lines with minimum-Y-extent.) The relevant portion of gregorian.ly defined a layout for printing naked neumes, with no visible staff. The function of that line, setting the height of that invisible staff to zero, is not actually used anywhere in the Google-able portion of lilypond.org, but the 2.13 equivalent gives the same output the old method, in case anyone uses this layout to make a vertical stack of naked neumes.

Patch Set 1 #

Patch Set 2 : Oops, forgot to update for new syntax. #

Patch Set 3 : Fix commit message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -89 lines) Patch
M Documentation/notation/ancient.itely View 2 chunks +17 lines, -49 lines 0 comments Download
M Documentation/notation/percussion.itely View 1 chunk +0 lines, -1 line 0 comments Download
M Documentation/notation/spacing.itely View 1 chunk +0 lines, -3 lines 0 comments Download
M Documentation/web/ly-examples/cary.ly View 3 chunks +1 line, -3 lines 0 comments Download
M Documentation/web/ly-examples/cary-layout.ily View 2 chunks +2 lines, -1 line 0 comments Download
M Documentation/web/ly-examples/orchestra.ly View 3 chunks +5 lines, -30 lines 0 comments Download
M ly/gregorian.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Graham Percival (old account)
Patch from Keith; long commit message explaining stuff.
13 years, 5 months ago (2010-11-19 04:53:21 UTC) #1
Patrick McCarty
Thanks for your work, Keith. I tested all of the changed snippets, and I didn't ...
13 years, 5 months ago (2010-11-19 07:41:46 UTC) #2
Graham Percival
On Fri, Nov 19, 2010 at 07:41:46AM +0000, pnorcks@gmail.com wrote: > One question about the ...
13 years, 5 months ago (2010-11-19 07:50:32 UTC) #3
Graham Percival (old account)
13 years, 5 months ago (2010-11-20 19:55:44 UTC) #4
On 2010/11/19 07:41:46, Patrick McCarty wrote:
> One question about the commit message: it mentions "engravers-one-by-one.ly",
> but there are no changes to this file in your patch.  Should there be changes?

This has been removed from the commit message.
 
> Otherwise, looks good to me.

Thanks, pushed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b