Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(174)

Issue 32088: Describe os:HttpRequest format and error handling (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
17 years, 3 months ago by awiner
Modified:
16 years, 11 months ago
Reviewers:
Base URL:
http://opensocial-resources.googlecode.com/svn/spec/
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Improve error content per lryan review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -0 lines) Patch
M draft/OpenSocial-Data-Pipelining.xml View 1 2 chunks +76 lines, -0 lines 0 comments Download

Messages

Total messages: 1
louiscryan
17 years, 3 months ago (2009-04-01 04:46:05 UTC) #1
One comment about errors, otherwise +1

http://codereview.appspot.com/32088/diff/1/2
File draft/OpenSocial-Data-Pipelining.xml (right):

http://codereview.appspot.com/32088/diff/1/2#newcode210
Line 210: message: 'Resource not found'
Should clarify some things about errors.

message should be a description of the HTTP status code mapped into error and
not the body of the HTTP error response. Use the additional 'data' field to
include headers, and actual response message body which can have type just as
non-error responses do

. E.g.

{error : {
   code : 404,
   message : 'Resource not found',
   data : {
     content : "...<escaped html>...",
     headers: {'Content-Type': ["text/html"]}
  }
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b