Issue 3205041: code review 3205041: 6c: automatically #define _64BIT.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3205041: code review 3205041: 6c: automatically #define _64BIT. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 7 months ago by iant

Modified:
14 years, 7 months ago

Reviewers:

CC:
ken2, rsc, golang-dev

Visibility:
Public.

Description

6c: automatically #define _64BIT. This makes it much easier to use a tool like Swig which needs to run either 8c or 6c on generated code which #include's "runtime.h".

Patch Set 1 #

Patch Set 2 : code review 3205041: 6c: automatically #define _64BIT. #

Created: 14 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/cmd/6c/txt.c	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello ken2, rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 7 months ago (2010-11-18 17:25:21 UTC) #1

iant

14 years, 7 months ago (2010-11-18 18:26:50 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=dd7ae2dcc39d ***

6c: automatically #define _64BIT.

This makes it much easier to use a tool like Swig which needs
to run either 8c or 6c on generated code which #include's
"runtime.h".

R=ken2, rsc
CC=golang-dev
http://codereview.appspot.com/3205041

Expand All Messages | Collapse All Messages