Issue 3200041: code review 3200041: index/suffixarray: use sort.Search

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3200041: code review 3200041: index/suffixarray: use sort.Search (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 7 months ago by rsc

Modified:
14 years, 7 months ago

Reviewers:

CC:
gri, golang-dev

Visibility:
Public.

Patch Set 2 : code review 3200041: index/suffixarray: use sort.Search #

Total comments: 1

Patch Set 3 : code review 3200041: index/suffixarray: use sort.Search #

Created: 14 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -20 lines)			Patch
	M	src/pkg/index/suffixarray/suffixarray.go	View	1 2	2 chunks	+2 lines, -20 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello gri (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 7 months ago (2010-11-18 12:49:57 UTC) #1

rsc

It's possible that the allocation here is too costly, but my thinking was that searches ...

14 years, 7 months ago (2010-11-18 12:52:44 UTC) #2

gri

LGTM http://codereview.appspot.com/3200041/diff/2001/src/pkg/index/suffixarray/suffixarray.go File src/pkg/index/suffixarray/suffixarray.go (right): http://codereview.appspot.com/3200041/diff/2001/src/pkg/index/suffixarray/suffixarray.go#newcode74 src/pkg/index/suffixarray/suffixarray.go:74: // x.at(i) <= s < x.at(i+1) this comment ...

14 years, 7 months ago (2010-11-18 17:14:35 UTC) #3

gri

I assume you are referring to closure allocation? I don't think it matters at all; ...

14 years, 7 months ago (2010-11-18 17:15:57 UTC) #4

rsc

14 years, 7 months ago (2010-11-19 21:04:29 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=21a04f7f394c ***

index/suffixarray: use sort.Search

R=gri
CC=golang-dev
http://codereview.appspot.com/3200041

Expand All Messages | Collapse All Messages