Issue 3174041: Allow zero text size to be specified for an SkPaint....

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3174041: Allow zero text size to be specified for an SkPaint....

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by jamesr

Modified:
13 years, 5 months ago

Reviewers:
Stephen White, agl, Steve VanDeBogart

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/src/

Visibility:
Public.

Description

Allow zero text size to be specified for an SkPaint. We have to support zero sized fonts and generate correct metrics to pass Acid3. There don't seem to be any requirements that textsize be >0, just that it not be negative.

Patch Set 1 #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	core/SkPaint.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

jamesr

This is a companion to https://bugs.webkit.org/show_bug.cgi?id=49638. As far as I can tell an fTextSize of ...

13 years, 5 months ago (2010-11-17 21:13:49 UTC) #1

LGTM if it looks good to the layout tests.

Expand All Messages | Collapse All Messages