Issue 3023041: code review 3023041: Big sync from internal version:

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3023041: code review 3023041: Big sync from internal version: (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by dsymonds

Modified:
15 years ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

Big sync from internal version: - include MessageSet support code - support message_set_wire_format for extensions - use append throughout encode.go

Patch Set 1 #

Patch Set 2 : code review 3023041: Big sync from internal version: #

Patch Set 3 : code review 3023041: Big sync from internal version: #

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+291 lines, -33 lines)			Patch
M	.hgignore	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	compiler/generator/generator.go	View	3 chunks	+22 lines, -2 lines	0 comments	Download
M	compiler/testdata/extension_base.proto	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	compiler/testdata/extension_test.go	View	2 chunks	+42 lines, -0 lines	0 comments	Download
M	compiler/testdata/extension_user.proto	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	compiler/testdata/test.pb.go.golden	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	proto/Makefile	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	proto/encode.go	View	5 chunks	+21 lines, -27 lines	0 comments	Download
A	proto/message_set.go	View	1 chunk	+180 lines, -0 lines	0 comments	Download
M	proto/testdata/test.pb.go	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	proto/text.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	proto/text_parser.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years ago (2010-11-10 22:51:07 UTC) #1

dsymonds

15 years ago (2010-11-10 23:06:25 UTC) #3

*** Submitted as b61c0315eabf ***

	Big sync from internal version:
          - include MessageSet support code
          - support message_set_wire_format for extensions
          - use append throughout encode.go

R=r
CC=golang-dev
http://codereview.appspot.com/3023041

Expand All Messages | Collapse All Messages