code review 2984041: doc/codewalk: update for changes in log package

doc/codewalk: update for changes in log package

[aam, 2010-11-08 16:25:31]

Hello adg (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r, 2010-11-08 17:50:00]

http://codereview.appspot.com/2984041/diff/2001/doc/codewalk/urlpoll.go
File doc/codewalk/urlpoll.go (right):

http://codereview.appspot.com/2984041/diff/2001/doc/codewalk/urlpoll.go#newco...
doc/codewalk/urlpoll.go:56: log.SetOutput(os.Stdout)
drop this. stderr is fine.

http://codereview.appspot.com/2984041/diff/2001/doc/codewalk/urlpoll.go#newco...
doc/codewalk/urlpoll.go:57: log.Println(os.Stdout, "Current state:")
s/os.Stdout, //
that's just wrong.

http://codereview.appspot.com/2984041/diff/2001/doc/codewalk/urlpoll.go#newco...
doc/codewalk/urlpoll.go:74: log.SetOutput(os.Stderr)
ditto
(in an case, if you wanted this behavior to be global it should be in init())

[aam, 2010-11-08 17:56:59]

Hello adg, r (cc: golang-dev@googlegroups.com),

Please take another look.

[aam, 2010-11-08 17:58:26]

http://codereview.appspot.com/2984041/diff/2001/doc/codewalk/urlpoll.go
File doc/codewalk/urlpoll.go (right):

http://codereview.appspot.com/2984041/diff/2001/doc/codewalk/urlpoll.go#newco...
doc/codewalk/urlpoll.go:56: log.SetOutput(os.Stdout)
On 2010/11/08 17:50:01, r wrote:
> drop this. stderr is fine.

Done.

http://codereview.appspot.com/2984041/diff/2001/doc/codewalk/urlpoll.go#newco...
doc/codewalk/urlpoll.go:57: log.Println(os.Stdout, "Current state:")
On 2010/11/08 17:50:01, r wrote:
> s/os.Stdout, //
> that's just wrong.

oops, shouldn't have been included.

http://codereview.appspot.com/2984041/diff/2001/doc/codewalk/urlpoll.go#newco...
doc/codewalk/urlpoll.go:74: log.SetOutput(os.Stderr)
On 2010/11/08 17:50:01, r wrote:
> ditto
> (in an case, if you wanted this behavior to be global it should be in init())

Done.

[r, 2010-11-08 17:59:04]

LGTM

[r, 2010-11-08 17:59:07]

*** Submitted as http://code.google.com/p/go/source/detail?r=95f19c083efc ***

doc/codewalk: update for changes in log package

R=adg, r
CC=golang-dev
http://codereview.appspot.com/2984041

Committer: Rob Pike <r@golang.org>