Issue 2968042: vertical spacing: Rename properties.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2968042: vertical spacing: Rename properties. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by Mark Polesky

Modified:
10 years, 8 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

vertical spacing: Rename properties.

Patch Set 1 #

Patch Set 2 : vertical spacing: Sort grob-properties. #

Patch Set 3 : vertical spacing: Update convert-ly. #

Patch Set 4 : vertical spacing: Convert affected regtests. #

Patch Set 5 : vertical spacing: Rename/revise affected regtests. #

Patch Set 6 : vertical spacing: Convert affected docs. #

Patch Set 7 : Doc: Vertical spacing naming format; nitpicks. #

Patch Set 8 : All 7 commits in one patch set. #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+327 lines, -276 lines)			Patch
M	Documentation/de/notation/spacing.itely	View		7 chunks	+21 lines, -21 lines	0 comments	Download
M	Documentation/es/learning/fundamental.itely	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	Documentation/es/notation/spacing.itely	View		7 chunks	+21 lines, -21 lines	0 comments	Download
M	Documentation/learning/fundamental.itely	View	6 7	4 chunks	+10 lines, -10 lines	0 comments	Download
M	Documentation/notation/changing-defaults.itely	View	6 7	6 chunks	+13 lines, -13 lines	0 comments	Download
M	Documentation/notation/spacing.itely	View	6 7	18 chunks	+69 lines, -50 lines	0 comments	Download
M	input/regression/page-breaking-min-distance2.ly	View	4 5	1 chunk	+6 lines, -3 lines	0 comments	Download
D	input/regression/page-spacing-loose-lines-non-affinity.ly	View	4 5	1 chunk	+0 lines, -13 lines	0 comments	Download
A +	input/regression/page-spacing-nonstaff-lines-and-markup.ly	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A +	input/regression/page-spacing-nonstaff-lines-between.ly	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	input/regression/page-spacing-nonstaff-lines-between-systems.ly	View		1 chunk	+3 lines, -3 lines	0 comments	Download
A +	input/regression/page-spacing-nonstaff-lines-bottom.ly	View	5	1 chunk	+4 lines, -4 lines	0 comments	Download
A +	input/regression/page-spacing-nonstaff-lines-header-padding.ly	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A +	input/regression/page-spacing-nonstaff-lines-top.ly	View	5	1 chunk	+4 lines, -4 lines	0 comments	Download
A	input/regression/page-spacing-nonstaff-lines-unrelated.ly	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	input/regression/page-spacing-staff-group-hara-kiri.ly	View	4 5	3 chunks	+6 lines, -5 lines	0 comments	Download
M	input/regression/page-spacing-stretchability.ly	View	4 5	1 chunk	+10 lines, -9 lines	0 comments	Download
M	lily/axis-group-interface.cc	View		6 chunks	+24 lines, -24 lines	0 comments	Download
M	lily/include/axis-group-interface.hh	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	lily/page-layout-problem.cc	View		5 chunks	+15 lines, -14 lines	0 comments	Download
M	lily/staff-grouper-interface.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	ly/engraver-init.ly	View		5 chunks	+19 lines, -12 lines	0 comments	Download
M	python/convertrules.py	View		2 chunks	+16 lines, -4 lines	0 comments	Download
M	scm/define-grob-properties.scm	View	1 2	8 chunks	+47 lines, -42 lines	0 comments	Download
M	scm/define-grobs.scm	View		3 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Mark Polesky

Here's a patch set for this big syntax change. I went with "withingroup" since it ...

13 years, 5 months ago (2010-11-08 16:47:06 UTC) #1

Mark Polesky

13 years, 5 months ago (2010-11-10 04:16:25 UTC) #2

On 2010/11/08 16:47:06, Mark Polesky wrote:
> Here's a patch set for this big syntax change.  I went with
> "withingroup" since it got more votes.  Okay to push?
> 
> - Mark

Please ignore this patch set for right now.  I'm preparing
another one that I think is a lot better.

- Mark

Expand All Messages | Collapse All Messages