Issue 2950041: Common container fixes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2950041: Common container fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by mhermanto

Modified:
13 years, 2 months ago

Reviewers:
dev-remailer, Han Nguyen, qiaoysun

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

More details on http://codereview.appspot.com/2897041.

Patch Set 1 #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+72 lines, -11 lines)			Patch
features/src/main/javascript/features/container/gadget_holder.js	View	2 chunks	+53 lines, -0 lines	0 comments	Download
features/src/main/javascript/features/container/service.js	View	3 chunks	+4 lines, -4 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java	View	4 chunks	+3 lines, -4 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java	View	1 chunk	+2 lines, -0 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java	View	2 chunks	+10 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

qiaoysun

13 years, 6 months ago (2010-11-06 04:18:57 UTC) #2

On 2010/11/06 03:04:31, mhermanto wrote:
Thanks!

To the change in gadget_holder.js, we need remove the line before the pubsub2
feature :
this.el_.innerHTML = this.getIframeHtml_();

To the change in service.js and GadgetsHandler.java: if we change the method to
gadgets.metadata, why register them again? it will get a warning message : 
Skipping duplicate osapi method definition gadgets.metadata on transport
http://localhost:8080/rpc. 
So I suggest to remove those lines in service.js:
osapiServicesConfig[endPoint] = [
    'gadgets.metadata', // without .get
    'gadgets.token' // without .get
  ];

Expand All Messages | Collapse All Messages