code review 2932041: net: fix windows build

net: fix windows build

[vcc, 2010-11-05 16:19:00]

Hello golang-dev@googlegroups.com (cc: vcc),

I'd like you to review this change.

[rsc, 2010-11-05 17:23:36]

I don't think we need to make a copy of isDomainName just to
satisfy a test.  For now let's do

func isDomainName(s string) bool {
    panic("unimplemented")
}

and then in the test do

if runtime.GOOS == "windows" {
    return
}

[rsc, 2010-11-05 17:23:59]

I don't think we need to make a copy of isDomainName just to
satisfy a test.  For now let's do

func isDomainName(s string) bool {
    panic("unimplemented")
}

and then in the test do

if runtime.GOOS == "windows" {
    return
}

[vcc, 2010-11-06 01:53:11]

Please take another look.

On 2010/11/05 17:23:59, rsc wrote:
> I don't think we need to make a copy of isDomainName just to
> satisfy a test.  For now let's do
> 
> func isDomainName(s string) bool {
>     panic("unimplemented")
> }
> 
> and then in the test do
> 
> if runtime.GOOS == "windows" {
>     return
> }

Done.

[rsc1, 2010-11-06 03:08:02]

LGTM

[rsc, 2010-11-06 03:08:23]

*** Submitted as http://code.google.com/p/go/source/detail?r=900cfd2def17 ***

net: fix windows build

R=rsc
CC=golang-dev
http://codereview.appspot.com/2932041

Committer: Russ Cox <rsc@golang.org>

[brainman, 2010-11-06 04:43:28]

LGTM