Issue 2926042: code review 2926042: Sync changes to internal version:

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2926042: code review 2926042: Sync changes to internal version: (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by dsymonds

Modified:
14 years, 9 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

Sync changes to internal version: - use append built-in - remove NewT from commentary - some idiom changes

Patch Set 1 #

Patch Set 2 : code review 2926042: Sync changes to internal version: #

Patch Set 3 : code review 2926042: Sync changes to internal version: #

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -47 lines)			Patch
M	compiler/generator/generator.go	View	3 chunks	+3 lines, -24 lines	0 comments	Download
M	compiler/testdata/extension_test.go	View	6 chunks	+12 lines, -9 lines	0 comments	Download
M	proto/lib.go	View	4 chunks	+6 lines, -14 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 9 months ago (2010-11-06 03:05:23 UTC) #1

dsymonds

14 years, 9 months ago (2010-11-06 03:39:45 UTC) #3

*** Submitted as 1c7188aca995 ***

		Sync changes to internal version:
	        	- use append built-in
                        - remove NewT from commentary
	                - some idiom changes

R=r
CC=golang-dev
http://codereview.appspot.com/2926042

Expand All Messages | Collapse All Messages