Issue 2923041: code review 2923041: runtime: fix windows build

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2923041: code review 2923041: runtime: fix windows build (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by brainman

Modified:
14 years, 8 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

runtime: fix windows build

Patch Set 1 #

Patch Set 2 : code review 2923041: runtime: fix windows build #

Patch Set 3 : code review 2923041: runtime: fix windows build #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/runtime/windows/os.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

brainman

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 8 months ago (2010-11-05 04:35:13 UTC) #1

brainman

Russ, I did not like what I have found. Perhaps, if you suggest how to, ...

14 years, 8 months ago (2010-11-05 04:35:57 UTC) #2

brainman

*** Submitted as http://code.google.com/p/go/source/detail?r=ee3b2ccd33ea *** runtime: fix windows build R=rsc CC=golang-dev http://codereview.appspot.com/2923041

14 years, 8 months ago (2010-11-05 06:27:22 UTC) #3

rsc

14 years, 8 months ago (2010-11-05 12:49:43 UTC) #4

LGTM

Thanks very much for finding this.
I agree that this is not a good long-term solution, but
we should check it in to fix the build and then worry
about the right eventual fix.

The Plan 9 port has to deal with parsing the arguments
differently too.  I wonder if the current goargs should
be called goargs_unix and then each of the per-OS
files (might as well be $GOOS/thread.c) can have an
implementation.  windows/thread.c and plan9/thread.c
would have their own, and the others would call the
goargs_unix one.

Russ

Expand All Messages | Collapse All Messages