|
|
Patch Set 1 #
Total comments: 22
Patch Set 2 : Updated with improvements from pheller #Patch Set 3 : Added paragraph about active record #
Total comments: 5
Patch Set 4 : Added sentence about migration #MessagesTotal messages: 12
Bertrand, Your noes are entirely readable. I just thought I would contribute some modifications to improve readability in a few parts. --phil http://codereview.appspot.com/2884041/diff/1/news.rst File news.rst (right): http://codereview.appspot.com/2884041/diff/1/news.rst#newcode7 news.rst:7: users), the enhancement of the list views in the client and a bunch of ... "in the client, and many other developments." http://codereview.appspot.com/2884041/diff/1/news.rst#newcode13 news.rst:13: Most of the methods signatures have been simplified, also access and ... "simplified. Also, access and modification of transactions are now cleanly wrapped within a transaction manager." http://codereview.appspot.com/2884041/diff/1/news.rst#newcode17 news.rst:17: This development that impacted around 6000 lines in the server core ... "development, which impacted approximately" http://codereview.appspot.com/2884041/diff/1/news.rst#newcode18 news.rst:18: (hence not counting modifications inside modules) brings two main "(excluding modules)," (note the comma after the close parentheses) http://codereview.appspot.com/2884041/diff/1/news.rst#newcode23 news.rst:23: - The new transaction manager provide a safe way to interact with provides http://codereview.appspot.com/2884041/diff/1/news.rst#newcode24 news.rst:24: transactions. This means less bugs and less security flaws. fewer bugs and fewer security flaws. http://codereview.appspot.com/2884041/diff/1/news.rst#newcode26 news.rst:26: Finally by reducing the existing code size, this modification ease Finally, (note comma) http://codereview.appspot.com/2884041/diff/1/news.rst#newcode26 news.rst:26: Finally by reducing the existing code size, this modification ease ... "this modification simplifies maintenance, reduces bugfix time, and improves readability." http://codereview.appspot.com/2884041/diff/1/news.rst#newcode34 news.rst:34: visible for the users: The client now provide pagination on list provides http://codereview.appspot.com/2884041/diff/1/news.rst#newcode35 news.rst:35: views. This mainly reduce the time GTK needs to display the list, reduces http://codereview.appspot.com/2884041/diff/1/news.rst#newcode36 news.rst:36: hence the client is more responsive on very big lists while keeping ... "lists, " (note comma) http://codereview.appspot.com/2884041/diff/1/news.rst#newcode37 news.rst:37: his usage nearly unchanged. Moreover, The search limit is now delete "his" http://codereview.appspot.com/2884041/diff/1/news.rst#newcode41 news.rst:41: Other novelties "Other Improvements" http://codereview.appspot.com/2884041/diff/1/news.rst#newcode44 news.rst:44: * New trigger mechanism. This allow to trigger custom actions when a This allows custom actions to be triggered when a.... http://codereview.appspot.com/2884041/diff/1/news.rst#newcode45 news.rst:45: given condition is met and when a record is created, deleted, ... "is met: when a" ... http://codereview.appspot.com/2884041/diff/1/news.rst#newcode48 news.rst:48: * Better integration of the GTK client in Mac OS. Mac OS X http://codereview.appspot.com/2884041/diff/1/news.rst#newcode50 news.rst:50: * Timestamp sequence, which allow numbering of document with respect "allows" "documents" http://codereview.appspot.com/2884041/diff/1/news.rst#newcode55 news.rst:55: format. This is important when data are exchanged through XML-RPC when data is exchanged http://codereview.appspot.com/2884041/diff/1/news.rst#newcode57 news.rst:57: enough precise. Thus detection of conflicting changes is now more precise enough.
Sign in to reply to this message.
http://codereview.appspot.com/2884041/diff/1/news.rst File news.rst (right): http://codereview.appspot.com/2884041/diff/1/news.rst#newcode15 news.rst:15: wrapped inside a transaction manager. I will add that it is the first step to the Active Record Pattern.
Sign in to reply to this message.
Great news! Thx for proof reading pheller!
Sign in to reply to this message.
http://codereview.appspot.com/2884041/diff/1/news.rst File news.rst (right): http://codereview.appspot.com/2884041/diff/1/news.rst#newcode15 news.rst:15: wrapped inside a transaction manager. On 2010/11/04 07:19:10, ced wrote: > I will add that it is the first step to the Active Record Pattern. I'm not comfortable with this: 1. this would need to explain what is the active record pattern, 2. this is really not obvious why transaction management is needed for AR, 3. are we sure that we want to implement AR in tryton (a news is an official announcement).
Sign in to reply to this message.
http://codereview.appspot.com/2884041/diff/1/news.rst File news.rst (right): http://codereview.appspot.com/2884041/diff/1/news.rst#newcode15 news.rst:15: wrapped inside a transaction manager. On 2010/11/04 12:12:19, bch wrote: > On 2010/11/04 07:19:10, ced wrote: > > I will add that it is the first step to the Active Record Pattern. > > I'm not comfortable with this: > 1. this would need to explain what is the active record pattern, http://en.wikipedia.org/wiki/Active_record > 2. this is really not obvious why transaction management is needed for AR, because cursor, user and context should be removed to have it > 3. are we sure that we want to implement AR in tryton (a news is an official > announcement). Yes. The current design inherited from OpenERP is crappy, too complicated for beginer and not very pythonic. http://groups.google.com/group/tryton-dev/browse_thread/thread/b0da76a80856f2...
Sign in to reply to this message.
Looks good! http://codereview.appspot.com/2884041/diff/10001/news.rst File news.rst (right): http://codereview.appspot.com/2884041/diff/10001/news.rst#newcode26 news.rst:26: of the Active Record Pattern (TODO link) in the ORM. This will Maybe this? http://en.wikipedia.org/wiki/Active_record_pattern Or even better this: http://books.google.com/books?id=FyWZt5DdvFkC&lpg=PA1&dq=Patterns%20of%20Ente...
Sign in to reply to this message.
http://codereview.appspot.com/2884041/diff/10001/news.rst File news.rst (right): http://codereview.appspot.com/2884041/diff/10001/news.rst#newcode26 news.rst:26: of the Active Record Pattern (TODO link) in the ORM. This will On 2010/11/05 09:18:05, udono wrote: > Maybe this? > http://en.wikipedia.org/wiki/Active_record_pattern > Or even better this: > http://books.google.com/books?id=FyWZt5DdvFkC&lpg=PA1&dq=Patterns%2520of%2520... Shorter version of last link: http://goo.gl/iIlR7
Sign in to reply to this message.
http://codereview.appspot.com/2884041/diff/10001/news.rst File news.rst (right): http://codereview.appspot.com/2884041/diff/10001/news.rst#newcode26 news.rst:26: of the Active Record Pattern (TODO link) in the ORM. This will If you put a link for Active Record Pattern, you should also put one for ORM, e.g. http://en.wikipedia.org/wiki/Object-relational_mapping http://codereview.appspot.com/2884041/diff/10001/news.rst#newcode31 news.rst:31: simplify maintenance, reduces bugfix time, and improves readability. simplifies ... (bug-fix|bug fix)
Sign in to reply to this message.
http://codereview.appspot.com/2884041/diff/10001/news.rst File news.rst (right): http://codereview.appspot.com/2884041/diff/10001/news.rst#newcode42 news.rst:42: per user in the client. We could also add the fix a memory leak.
Sign in to reply to this message.
There is also the functionality that allow to run Neso completely on USB key.
Sign in to reply to this message.
|