Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(71)

Issue 2819041: Use strings.Contains in src/cmd/... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 8 months ago by brad_danga_com
Modified:
14 years, 7 months ago
Reviewers:
CC:
r, golang-dev, r2, rsc
Visibility:
Public.

Description

Use strings.Contains in src/cmd/...

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/cmd/cgo/gcc.go View 1 chunk +4 lines, -4 lines 0 comments Download
M src/cmd/goinstall/download.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
brad_danga_com
Not too many in cmd...
14 years, 8 months ago (2010-11-01 22:04:54 UTC) #1
rsc
LGTM
14 years, 8 months ago (2010-11-01 22:07:52 UTC) #2
r2
LGTM
14 years, 8 months ago (2010-11-01 22:08:05 UTC) #3
rsc
leaving for rob to submit
14 years, 8 months ago (2010-11-01 22:08:42 UTC) #4
r
14 years, 8 months ago (2010-11-01 22:21:39 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=a8d0b423738e ***

Use strings.Contains in src/cmd/...

R=r
CC=golang-dev, r2, rsc
http://codereview.appspot.com/2819041

Committer: Rob Pike <r@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b