code review 2817041: go/printer: do not remove parens around composite liter...

go/printer: do not remove parens around composite literals starting with a type name in control clauses
(even when they are nested inside an expression).

Fixes issue 1243.

[gri, 2010-11-01 21:37:54]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc1, 2010-11-01 22:01:23]

LGTM

http://codereview.appspot.com/2817041/diff/3001/src/pkg/go/printer/nodes.go
File src/pkg/go/printer/nodes.go (right):

http://codereview.appspot.com/2817041/diff/3001/src/pkg/go/printer/nodes.go#n...
src/pkg/go/printer/nodes.go:801: // TODO(gri) make this more general and
incorporate precedence levels
Do you mean that you plan to strip all unnecessary parentheses during printing?
I won't object but it seems aggressive.

[gri, 2010-11-01 22:07:47]

On Mon, Nov 1, 2010 at 3:01 PM, <rsc@google.com> wrote:

> LGTM
>
>
>
> http://codereview.appspot.com/2817041/diff/3001/src/pkg/go/printer/nodes.go
> File src/pkg/go/printer/nodes.go (right):
>
>
>
http://codereview.appspot.com/2817041/diff/3001/src/pkg/go/printer/nodes.go#n...
> src/pkg/go/printer/nodes.go:801: // TODO(gri) make this more general and
> incorporate precedence levels
> Do you mean that you plan to strip all unnecessary parentheses during
> printing?
> I won't object but it seems aggressive.


I changed the wording to "consider ..."


>
>
> http://codereview.appspot.com/2817041/
>

[gri, 2010-11-01 22:08:05]

*** Submitted as http://code.google.com/p/go/source/detail?r=dc31bff57d34 ***

go/printer: do not remove parens around composite literals starting with a type
name in control clauses
(even when they are nested inside an expression).

Fixes issue 1243.

R=rsc
CC=golang-dev
http://codereview.appspot.com/2817041

[peterGo, 2010-11-01 23:29:52]

> Fixes issue 1243.

I still have issue 1243: hg id 77bee7a9b622 tip.
1243.go:7: syntax error: unexpected }, expecting := or = or comma

package main

type T [3]int

func main() {
	var a, b, c, i, x int
	if (x == T{a, b, c}[i]) {
	}
}

gofmt -w && 6g

On 2010/11/01 22:08:05, gri wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=dc31bff57d34 ***
> 
> go/printer: do not remove parens around composite literals starting with a
type
> name in control clauses
> (even when they are nested inside an expression).
> 
> Fixes issue 1243.
> 
> R=rsc
> CC=golang-dev
> http://codereview.appspot.com/2817041

[gri, 2010-11-01 23:42:40]

I cannot reproduce this anymore. Also, the tests in go/printer check this
case and the () are not removed. gofmt -w test.go && 6g test.go works for me
for this program.

Please verify that you are running the correct and re-built (i.e.,
re-linked) gofmt after updating.

- gri

On Mon, Nov 1, 2010 at 4:29 PM, <go.peter.90@gmail.com> wrote:

> package main
>
> type T [3]int
>
> func main() {
>        var a, b, c, i, x int
>        if (x == T{a, b, c}[i]) {
>        }
> }
>

[peterGo, 2010-11-02 00:56:37]

> Please verify that you are running the correct and re-built (i.e.,
> re-linked) gofmt after updating.

I downloaded a new copy of the repo; problem solved.