Issue 2813041: code review 2813041: mkrunetype: install a Makefile and tweak it slightly so...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2813041: code review 2813041: mkrunetype: install a Makefile and tweak it slightly so... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by r

Modified:
14 years, 8 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

mkrunetype: install a Makefile and tweak it slightly so it can be built.

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -11 lines)			Patch
	A	src/lib9/utf/Makefile	View		1 chunk	+16 lines, -0 lines	0 comments	Download
	M	src/lib9/utf/mkrunetype.c	View	1	5 chunks	+8 lines, -11 lines	0 comments	Download

Total messages: 3

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 8 months ago (2010-11-01 00:46:24 UTC) #1

*** Submitted as http://code.google.com/p/go/source/detail?r=4e60bb339310 *** mkrunetype: install a Makefile and tweak it slightly so it ...

14 years, 8 months ago (2010-11-01 00:46:33 UTC) #2

rsc

14 years, 8 months ago (2010-11-01 15:09:48 UTC) #3

LGTM

I'm happy with building this program the same
way we build all our other programs.  I didn't even
know what half those header files did.