Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5137)

Issue 2810041: Doc: Removed [fragment] from @lilypond examples NR (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by Graham Percival (old account)
Modified:
13 years, 6 months ago
Reviewers:
carl.d.sorensen, Trevor Daniels
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: fixes for previous patch. Doc: Removed [fragment] from @lilypond examples NR Where appropriate replaced with [relative] or added { } construct within @lilypond example All except ancient.itely have been amended because some ancient music examples gave unexpected results.

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove [relative] from chordmode and figures. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -131 lines) Patch
M Documentation/notation/changing-defaults.itely View 20 chunks +20 lines, -20 lines 0 comments Download
M Documentation/notation/cheatsheet.itely View 24 chunks +30 lines, -30 lines 0 comments Download
M Documentation/notation/chords.itely View 1 31 chunks +36 lines, -36 lines 0 comments Download
M Documentation/notation/fretted-strings.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/notation/input.itely View 1 chunk +6 lines, -8 lines 0 comments Download
M Documentation/notation/percussion.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/notation/pitches.itely View 2 chunks +16 lines, -12 lines 0 comments Download
M Documentation/notation/spacing.itely View 8 chunks +8 lines, -8 lines 0 comments Download
M Documentation/notation/vocal.itely View 5 chunks +19 lines, -15 lines 0 comments Download

Messages

Total messages: 5
Graham Percival (old account)
Docs look ok, but I'm not 100% certain about the changes to chords, or whether ...
13 years, 6 months ago (2010-10-31 11:16:04 UTC) #1
Carl
I've only reviewed the chords section, since Graham was unsure about it. I think that ...
13 years, 6 months ago (2010-10-31 13:54:01 UTC) #2
Graham Percival (old account)
On 2010/10/31 13:54:01, Carl wrote: > I think the relative should only be included with ...
13 years, 6 months ago (2010-10-31 14:11:50 UTC) #3
Trevor Daniels
I'm happy with the changes to vocal.itely, although ragged-right could also be removed in many ...
13 years, 6 months ago (2010-11-01 18:35:14 UTC) #4
Graham Percival (old account)
13 years, 6 months ago (2010-11-02 19:48:52 UTC) #5
On 2010/11/01 18:35:14, Trevor Daniels wrote:
> I'm happy with the changes to vocal.itely, although ragged-right could also be
> removed in many (maybe all) of the @lilyponds.

Aye, [ragged-right] should be removed from (almost?) all @lilypond.  But this
patch is too big already.

Thanks, pushed.

Cheers,
- Graham
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b