Issue 2795041: code review 2795041: regexp: eliminate vector in favor of append.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2795041: code review 2795041: regexp: eliminate vector in favor of append. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by r

Modified:
14 years, 8 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

regexp: eliminate vector in favor of append.

Patch Set 2 : code review 2795041: regexp: eliminate vector in favor of append. #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -29 lines)			Patch
	M	src/pkg/regexp/regexp.go	View	1	15 chunks	+25 lines, -29 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 8 months ago (2010-10-28 22:14:06 UTC) #1

rsc1

LGTM http://codereview.appspot.com/2795041/diff/1/src/pkg/regexp/regexp.go File src/pkg/regexp/regexp.go (right): http://codereview.appspot.com/2795041/diff/1/src/pkg/regexp/regexp.go#newcode607 src/pkg/regexp/regexp.go:607: for i := 0; i < len(re.inst); i++ ...

14 years, 8 months ago (2010-10-28 22:24:22 UTC) #2

14 years, 8 months ago (2010-10-28 22:54:04 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=357243e7c3c2 ***

regexp: eliminate vector in favor of append.

R=rsc
CC=golang-dev
http://codereview.appspot.com/2795041

Expand All Messages | Collapse All Messages