Issue 2750041: code review 2750041: gob: must register basic types to store them interfaces.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2750041: code review 2750041: gob: must register basic types to store them interfaces. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by r

Modified:
14 years, 8 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

gob: must register basic types to store them in interfaces. Fixes issue 1230.

Patch Set 2 : code review 2750041: gob: must register basic types to store them in interfaces. #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -0 lines)			Patch
	M	src/pkg/gob/codec_test.go	View		1 chunk	+45 lines, -0 lines	0 comments	Download
	M	src/pkg/gob/type.go	View	1	2 chunks	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 8 months ago (2010-10-26 17:24:54 UTC) #1

rsc1

LGTM http://codereview.appspot.com/2750041/diff/1/src/pkg/gob/type.go File src/pkg/gob/type.go (right): http://codereview.appspot.com/2750041/diff/1/src/pkg/gob/type.go#newcode517 src/pkg/gob/type.go:517: Register(complex(0i)) s/i// http://codereview.appspot.com/2750041/diff/1/src/pkg/gob/type.go#newcode522 src/pkg/gob/type.go:522: Register([]byte("")) s/""/nil/

14 years, 8 months ago (2010-10-27 00:04:00 UTC) #2

14 years, 8 months ago (2010-10-27 00:07:45 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=c686f973d502 ***

gob: must register basic types to store them in interfaces.
Fixes issue 1230.

R=rsc
CC=golang-dev
http://codereview.appspot.com/2750041

Expand All Messages | Collapse All Messages