Issue 2743042: code review 2743042: use append

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2743042: code review 2743042: use append (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 6 months ago by rsc

Modified:
14 years, 6 months ago

Reviewers:

CC:
gri, r, r2, golang-dev

Visibility:
Public.

Description

use append

Patch Set 1 #

Patch Set 2 : code review 2743042: use append #

Patch Set 3 : code review 2743042: use append #

Patch Set 4 : code review 2743042: use append #

Created: 14 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+110 lines, -405 lines)			Patch
M	src/cmd/cgo/ast.go	View		3 chunks	+4 lines, -23 lines	0 comments	Download
M	src/cmd/cgo/gcc.go	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/cmd/cgo/util.go	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/cmd/hgpatch/main.go	View		2 chunks	+3 lines, -5 lines	0 comments	Download
M	src/cmd/prof/gopprof	View		3 chunks	+26 lines, -15 lines	0 comments	Download
M	src/pkg/bufio/bufio.go	View		3 chunks	+4 lines, -18 lines	0 comments	Download
M	src/pkg/bytes/bytes.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/crypto/tls/handshake_messages.go	View		1 chunk	+0 lines, -13 lines	0 comments	Download
M	src/pkg/crypto/x509/x509.go	View		3 chunks	+9 lines, -20 lines	0 comments	Download
M	src/pkg/debug/dwarf/type.go	View		2 chunks	+2 lines, -16 lines	0 comments	Download
M	src/pkg/debug/macho/file.go	View		1 chunk	+1 line, -9 lines	0 comments	Download
M	src/pkg/exp/eval/func.go	View		1 chunk	+1 line, -8 lines	0 comments	Download
M	src/pkg/exp/nacl/srpc/server.go	View		1 chunk	+1 line, -8 lines	0 comments	Download
M	src/pkg/exp/ogle/process.go	View		1 chunk	+1 line, -9 lines	0 comments	Download
M	src/pkg/flag/flag_test.go	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	src/pkg/go/ast/scope.go	View		1 chunk	+1 line, -9 lines	0 comments	Download
M	src/pkg/go/doc/comment.go	View		1 chunk	+1 line, -10 lines	0 comments	Download
M	src/pkg/go/doc/doc.go	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	src/pkg/html/token.go	View	1	1 chunk	+3 lines, -14 lines	0 comments	Download
M	src/pkg/image/format.go	View		1 chunk	+1 line, -9 lines	0 comments	Download
M	src/pkg/json/scanner.go	View		1 chunk	+1 line, -12 lines	0 comments	Download
M	src/pkg/net/hosts.go	View		2 chunks	+1 line, -13 lines	0 comments	Download
M	src/pkg/os/dir_darwin.go	View		1 chunk	+1 line, -7 lines	0 comments	Download
M	src/pkg/os/dir_freebsd.go	View		1 chunk	+1 line, -7 lines	0 comments	Download
M	src/pkg/os/dir_linux.go	View		1 chunk	+1 line, -7 lines	0 comments	Download
M	src/pkg/os/dir_nacl.go	View		1 chunk	+1 line, -7 lines	0 comments	Download
M	src/pkg/os/env_windows.go	View		1 chunk	+1 line, -7 lines	0 comments	Download
M	src/pkg/os/file_windows.go	View		1 chunk	+1 line, -7 lines	0 comments	Download
M	src/pkg/regexp/regexp.go	View		9 chunks	+33 lines, -97 lines	0 comments	Download
M	src/pkg/template/template.go	View		1 chunk	+1 line, -7 lines	0 comments	Download
M	src/pkg/testing/regexp.go	View		2 chunks	+2 lines, -19 lines	0 comments	Download
M	src/pkg/unicode/maketables.go	View		1 chunk	+1 line, -9 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello gri, r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 6 months ago (2010-10-28 00:54:33 UTC) #1

rsc

14 years, 6 months ago (2010-10-28 02:47:42 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=3ee58453e961 ***

use append

R=gri, r, r2
CC=golang-dev
http://codereview.appspot.com/2743042

Expand All Messages | Collapse All Messages