code review 2733042: 6l/8l: generate dwarf variable names with disambiguatin...

6l/8l: generate dwarf variable names with disambiguating suffix.

[lvd, 2010-10-28 20:15:42]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc1, 2010-11-01 19:30:18]

LGTM

http://codereview.appspot.com/2733042/diff/11002/src/cmd/ld/dwarf.c
File src/cmd/ld/dwarf.c (right):

http://codereview.appspot.com/2733042/diff/11002/src/cmd/ld/dwarf.c#newcode796
src/cmd/ld/dwarf.c:796: return (char*) p->p;				// the c-string
s/) /)/

http://codereview.appspot.com/2733042/diff/11002/src/cmd/ld/dwarf.c#newcode1515
src/cmd/ld/dwarf.c:1515: if (strstr( a->asym->name, ".autotmp_"))
no space after strstr(

[lvd, 2010-11-01 19:35:53]

http://codereview.appspot.com/2733042/diff/11002/src/cmd/ld/dwarf.c
File src/cmd/ld/dwarf.c (right):

http://codereview.appspot.com/2733042/diff/11002/src/cmd/ld/dwarf.c#newcode796
src/cmd/ld/dwarf.c:796: return (char*) p->p;				// the c-string
On 2010/11/01 19:30:18, rsc1 wrote:
> s/) /)/

Done.

http://codereview.appspot.com/2733042/diff/11002/src/cmd/ld/dwarf.c#newcode1515
src/cmd/ld/dwarf.c:1515: if (strstr( a->asym->name, ".autotmp_"))
On 2010/11/01 19:30:18, rsc1 wrote:
> no space after strstr(

Done.

[lvd, 2010-11-08 18:48:28]

*** Submitted as http://code.google.com/p/go/source/detail?r=adadb9816156 ***

6l/8l: generate dwarf variable names with disambiguating suffix.

R=rsc
CC=golang-dev
http://codereview.appspot.com/2733042

[lvd, 2010-11-08 18:49:02]

sorry, i thought i submitted this ages ago.  tested and submitted at last.

On Mon, Nov 8, 2010 at 19:48, <lvd@google.com> wrote:

> *** Submitted as
> http://code.google.com/p/go/source/detail?r=adadb9816156 ***
>
>
> 6l/8l: generate dwarf variable names with disambiguating suffix.
>
> R=rsc
> CC=golang-dev
>
> http://codereview.appspot.com/2733042
>
>
> http://codereview.appspot.com/2733042/
>