code review 2723041: http server: don't send trailing '0' for chunked encodi...

http server: don't send trailing '0' for chunked encoding when responding with 304 NotModified

[hoisie, 2010-10-25 22:57:57]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[hoisie, 2010-10-25 23:01:48]

Without this patch, the following code is triggered in finishRequest in
http/server.go, even when returning a 304:

    if w.chunking {
        io.WriteString(w.conn.buf, "0\r\n")
        // trailer key/value pairs, followed by blank line
        io.WriteString(w.conn.buf, "\r\n")
    }


On 2010/10/25 22:57:57, hoisie wrote:
> Hello rsc (cc: mailto:golang-dev@googlegroups.com),
> 
> I'd like you to review this change.

[hoisie, 2010-10-31 21:39:36]

ping, this is a trivial fix, it should apply cleanly

On 2010/10/25 23:01:48, hoisie wrote:
> Without this patch, the following code is triggered in finishRequest in
> http/server.go, even when returning a 304:
> 
>     if w.chunking {
>         io.WriteString(w.conn.buf, "0\r\n")
>         // trailer key/value pairs, followed by blank line
>         io.WriteString(w.conn.buf, "\r\n")
>     }
> 
> 
> On 2010/10/25 22:57:57, hoisie wrote:
> > Hello rsc (cc: mailto:golang-dev@googlegroups.com),
> > 
> > I'd like you to review this change.

[adg, 2010-11-01 05:18:34]

LGTM

but I'll wait for rsc to submit.

On 1 November 2010 08:39,  <hoisie@gmail.com> wrote:
> ping, this is a trivial fix, it should apply cleanly
>
> On 2010/10/25 23:01:48, hoisie wrote:
>>
>> Without this patch, the following code is triggered in finishRequest
>
> in
>>
>> http/server.go, even when returning a 304:
>
>>     if w.chunking {
>>         io.WriteString(w.conn.buf, "0\r\n")
>>         // trailer key/value pairs, followed by blank line
>>         io.WriteString(w.conn.buf, "\r\n")
>>     }
>
>
>> On 2010/10/25 22:57:57, hoisie wrote:
>> > Hello rsc (cc: mailto:golang-dev@googlegroups.com),
>> >
>> > I'd like you to review this change.
>
>
>
> http://codereview.appspot.com/2723041/
>

[rsc, 2010-11-01 20:15:05]

*** Submitted as 289c31cc837a ***

http server: don't send trailing '0' for chunked encoding when responding with
304 NotModified

R=rsc, adg
CC=golang-dev
http://codereview.appspot.com/2723041

Committer: Russ Cox <rsc@golang.org>