code review 2717043: go spec: append is now implemented

go spec: append is now implemented

[gri, 2010-10-29 18:18:14]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r2, 2010-10-29 18:32:03]

LGTM

On Oct 29, 2010, at 11:18 AM, gri@golang.org wrote:

> Reviewers: r,
> 
> Message:
> Hello r (cc: golang-dev@googlegroups.com),
> 
> I'd like you to review this change.
> 
> 
> Description:
> go spec: append is now implemented
> 
> Please review this at http://codereview.appspot.com/2717043/
> 
> Affected files:
>  M doc/go_spec.html
> 
> 
> Index: doc/go_spec.html
> ===================================================================
> --- a/doc/go_spec.html
> +++ b/doc/go_spec.html
> @@ -1,5 +1,5 @@
> <!-- title The Go Programming Language Specification -->
> -<!-- subtitle Version of Oct 27, 2010 -->
> +<!-- subtitle Version of Oct 29, 2010 -->
> 
> <!--
> TODO
> @@ -4559,10 +4559,6 @@
> </pre>
> 
> <p>
> -<span class="alert">Note: <code>append</code> is not yet implemented.</span>
> -</p>
> -
> -<p>
> The function <code>copy</code> copies slice elements from
> a source <code>src</code> to a destination <code>dst</code> and returns the
> number of elements copied. Source and destination may overlap.
> @@ -5233,7 +5229,7 @@
> <h2 id="Implementation_differences"><span class="alert">Implementation
differences - TODO</span></h2>
> <ul>
> 	<li><span class="alert">Implementation does not honor the restriction on goto
statements and targets (no intervening declarations).</span></li>
> -	<li><span class="alert">The <code>append</code> built-in function is not yet
implemented.</span></li>
> +	<li><span class="alert">Gccgo: The <code>append</code> built-in function is
not yet implemented.</span></li>
> 	<li><span class="alert">Gccgo: Method expressions are partially
implemented.</span></li>
> 	<li><span class="alert">Gccgo: allows only one init() function per source
file.</span></li>
> </ul>
> 
> 

[gri, 2010-10-29 18:44:54]

*** Submitted as http://code.google.com/p/go/source/detail?r=02c580ac0f2d ***

go spec: append is now implemented

R=r, r2
CC=golang-dev
http://codereview.appspot.com/2717043