Hmm, I am getting a failure in AppTest now: There was 1 failure: 1) testImportUrlSetsNullVersionIfNoVersionHeaderOnFeed(Zend_Gdata_AppTest) ...
15 years, 1 month ago
(2009-03-25 00:13:35 UTC)
#2
Hmm,
I am getting a failure in AppTest now:
There was 1 failure:
1) testImportUrlSetsNullVersionIfNoVersionHeaderOnFeed(Zend_Gdata_AppTest)
Failed asserting that <integer:1> matches expected value <null>.
/Users/jhartmann/php_includes/trunk/tests/Zend/Gdata/AppTest.php:531
I think it's because I changed it so that if $(major|minor)ProtocolVersion is
null then we use self::DEFAULT_(MAJOR|MINOR)_PROTOCOL_VERSION which seems like
it would make sense...
Should I just keep it null to preserve the test or should the test instead be
changed to assert that if null it should be the value of the constant ?
- J
http://codereview.appspot.com/27107/diff/4/5 File App.php (right): http://codereview.appspot.com/27107/diff/4/5#newcode792 Line 792: * of the data model object that is ...
15 years, 1 month ago
(2009-03-25 01:13:40 UTC)
#4
Updated. Can you take another look? Thanks - J http://codereview.appspot.com/27107/diff/4/5 File App.php (right): http://codereview.appspot.com/27107/diff/4/5#newcode792 Line ...
15 years, 1 month ago
(2009-03-25 17:18:07 UTC)
#5
Issue 27107: Fix namespace propagation in App.php
(Closed)
Created 15 years, 1 month ago by api.jhartmann-google
Modified 14 years, 9 months ago
Reviewers: Trevor Johns (Google)
Base URL: http://framework.zend.com/svn/framework/standard/trunk/library/Zend/Gdata
Comments: 4