Issue 2695042: code review 2695042: goinstall: don't wrongly error out with "multiple packa...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2695042: code review 2695042: goinstall: don't wrongly error out with "multiple packa... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by fhs

Modified:
14 years, 8 months ago

Reviewers:

CC:
adg, rsc, golang-dev

Visibility:
Public.

Description

goinstall: don't wrongly error out with "multiple package names" Fixes issue 1215.

Patch Set 2 : code review 2695042: goinstall: don't wrongly error out with "multiple packa... #

Patch Set 3 : code review 2695042: goinstall: don't wrongly error out with "multiple packa... #

Total comments: 2

Patch Set 4 : code review 2695042: goinstall: don't wrongly error out with "multiple packa... #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/cmd/goinstall/parse.go	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

fhs

Hello adg, rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 8 months ago (2010-10-24 19:53:07 UTC) #1

adg

http://codereview.appspot.com/2695042/diff/8001/src/cmd/goinstall/parse.go File src/cmd/goinstall/parse.go (right): http://codereview.appspot.com/2695042/diff/8001/src/cmd/goinstall/parse.go#newcode56 src/cmd/goinstall/parse.go:56: if s != "main" && allowMain { A simpler ...

14 years, 8 months ago (2010-10-25 00:30:17 UTC) #2

fhs

PTAL http://codereview.appspot.com/2695042/diff/8001/src/cmd/goinstall/parse.go File src/cmd/goinstall/parse.go (right): http://codereview.appspot.com/2695042/diff/8001/src/cmd/goinstall/parse.go#newcode56 src/cmd/goinstall/parse.go:56: if s != "main" && allowMain { On ...

14 years, 8 months ago (2010-10-25 02:01:04 UTC) #3

adg

*** Submitted as http://code.google.com/p/go/source/detail?r=17dbdd6c834f *** goinstall: don't wrongly error out with "multiple package names" Fixes ...

14 years, 8 months ago (2010-10-25 02:13:07 UTC) #4

adg

14 years, 8 months ago (2010-10-25 02:13:17 UTC) #5

LGTM

On 25 October 2010 13:01,  <fshahriar@gmail.com> wrote:
> PTAL
>
>
> http://codereview.appspot.com/2695042/diff/8001/src/cmd/goinstall/parse.go
> File src/cmd/goinstall/parse.go (right):
>
>
http://codereview.appspot.com/2695042/diff/8001/src/cmd/goinstall/parse.go#ne...
> src/cmd/goinstall/parse.go:56: if s != "main" && allowMain {
> On 2010/10/25 00:30:17, adg wrote:
>>
>> A simpler fix is to leave the test where it was, and change the
>
> condition:
>
>> if s == "main" || pkgName == "main" {
>
> Done.
>
> http://codereview.appspot.com/2695042/
>

Expand All Messages | Collapse All Messages