code review 2674041: 8l, runtime: fix Plan 9 386 build.

8l, runtime: fix Plan 9 386 build.
8l was broken by commit 7ac0d2eed9, it caused .data to be page aligned in the file - which is not how Plan 9 expects things to be. 
Also .rodata was layed out in a similar fashion.

Not sure when signame was introduced, but added a stub.
Removed the symo assignment in asm.c as it is not currently used.

Fix runtime breakage after commit 629c065d36 which prefixes all external symbols with runtime·.

[paulzhol, 2010-10-22 15:34:01]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc1, 2010-11-01 19:27:29]

Sorry about breaking the build.  I think we can probably do
something simpler than what's here, like just putting the 
va = rnd(va, INITRND) in its own if statement.

http://codereview.appspot.com/2674041/diff/18001/src/cmd/ld/data.c
File src/cmd/ld/data.c (right):

http://codereview.appspot.com/2674041/diff/18001/src/cmd/ld/data.c#newcode739
src/cmd/ld/data.c:739: if (HEADTYPE == 2)
This isn't right, because ld/data.c is used by all linkers.
It would be if(thechar == '8' && HEADTYPE == 2), but
I'd also like to avoid having specific things here.
The old code here would be fine as long as you 
used INITRND = 1 above, for example.

http://codereview.appspot.com/2674041/diff/18001/src/pkg/runtime/plan9/386/si...
File src/pkg/runtime/plan9/386/signal.c (right):

http://codereview.appspot.com/2674041/diff/18001/src/pkg/runtime/plan9/386/si...
src/pkg/runtime/plan9/386/signal.c:12: String	signame(int32 sig)
newline between String and signame (like surrounding code)

[paulzhol, 2010-11-01 23:27:35]

On 2010/11/01 19:27:29, rsc1 wrote:
> Sorry about breaking the build.  I think we can probably do
> something simpler than what's here, like just putting the 
> va = rnd(va, INITRND) in its own if statement.
> 
...
> http://codereview.appspot.com/2674041/diff/18001/src/cmd/ld/data.c#newcode739
> src/cmd/ld/data.c:739: if (HEADTYPE == 2)
> This isn't right, because ld/data.c is used by all linkers.
> It would be if(thechar == '8' && HEADTYPE == 2), but
> I'd also like to avoid having specific things here.
> The old code here would be fine as long as you 
> used INITRND = 1 above, for example.

Hi, 
I haven't tried it yet, but it seems that setting INITRND = 1 would address the
problem of .code and .rodata sections being page aligned but I still need a va =
rnd(va, 4096) before segdata.vaddr is set if (thechar == '8' && HEADTYPE == 2).

Maybe I could fiddle with the seek calls in asmb() if it is the more appropriate
location ?

[paulzhol, 2010-11-02 19:54:43]

Hi Russ,

I've hg synced my code and saw how it is done in commit bfbe64e3e8 (8l: pe
generation fixes) for src/cmd/ld/data.c.

I've tried something similar - please take another look.

Thanks,
Pavel

http://codereview.appspot.com/2674041/diff/18001/src/cmd/ld/data.c
File src/cmd/ld/data.c (right):

http://codereview.appspot.com/2674041/diff/18001/src/cmd/ld/data.c#newcode739
src/cmd/ld/data.c:739: if (HEADTYPE == 2)
On 2010/11/01 19:27:29, rsc1 wrote:
> This isn't right, because ld/data.c is used by all linkers.
> It would be if(thechar == '8' && HEADTYPE == 2), but
> I'd also like to avoid having specific things here.
> The old code here would be fine as long as you 
> used INITRND = 1 above, for example.

Done, set INITRND = 1 in obj.c for HEADTYPE==2 and called rnd with 4096.
Should I add an aout.h and define a AOUTSEGALIGN=4096 like in pe.h?

http://codereview.appspot.com/2674041/diff/18001/src/pkg/runtime/plan9/386/si...
File src/pkg/runtime/plan9/386/signal.c (right):

http://codereview.appspot.com/2674041/diff/18001/src/pkg/runtime/plan9/386/si...
src/pkg/runtime/plan9/386/signal.c:12: String	signame(int32 sig)
On 2010/11/01 19:27:29, rsc1 wrote:
> newline between String and signame (like surrounding code)

Done.

[paulzhol, 2010-11-05 10:37:01]

synced against tip and added more function call renames after commit 629c065d36,
which prefixes all external symbols with runtime·.

[paulzhol, 2010-12-03 11:38:48]

synced against release.2010-12-02, added runtime_defs.go.

[rsc1, 2010-12-06 19:40:50]

LGTM

Thanks for staying on top of the breakage.
I fear there is more on its way with the new
cgo and garbage collector changes, but then
things should calm down.

[rsc, 2010-12-06 21:38:30]

*** Submitted as 91d2aeab0c2e ***

8l, runtime: fix Plan 9 386 build.
8l was broken by commit 7ac0d2eed9, it caused .data to be page aligned in the
file - which is not how Plan 9 expects things to be.
Also .rodata was layed out in a similar fashion.

Not sure when signame was introduced, but added a stub.
Removed the symo assignment in asm.c as it is not currently used.

Fix runtime breakage after commit 629c065d36 which prefixes all external symbols
with runtime·.

R=rsc
CC=golang-dev
http://codereview.appspot.com/2674041

Committer: Russ Cox <rsc@golang.org>