Issue 2664041: code review 2664041: codereview: fix 'hg sync' and 'hg download' in Python 2.7

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2664041: code review 2664041: codereview: fix 'hg sync' and 'hg download' in Python 2.7 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by fhs

Modified:
14 years, 8 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

codereview: fix 'hg sync' and 'hg download' in Python 2.7 Fixes issue 1218.

Patch Set 1 #

Patch Set 2 : code review 2664041: codereview: fix 'hg sync' in Python 2.7 #

Patch Set 3 : code review 2664041: codereview: fix 'hg sync' in Python 2.7 #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	lib/codereview/codereview.py	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

fhs

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 8 months ago (2010-10-22 01:38:13 UTC) #1

fhs

Also added the same fix for 'hg download' On 2010/10/22 01:38:13, fhs wrote: > Hello ...

14 years, 8 months ago (2010-10-22 02:11:01 UTC) #2

rsc

14 years, 8 months ago (2010-11-01 20:37:21 UTC) #4

*** Submitted as 63659cc70880 ***

codereview: fix 'hg sync' and 'hg download' in Python 2.7

Fixes issue 1218.

R=rsc
CC=golang-dev
http://codereview.appspot.com/2664041

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages