Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(443)

Issue 2645042: code review 2645042: bug right shifting 64 bits (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 8 months ago by ken3
Modified:
14 years, 8 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

bug right shifting 64 bits by a variable that equals 32

Patch Set 1 #

Patch Set 2 : code review 2645042: bug right shifting 64 bits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/cmd/5g/cgen64.c View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3
ken3
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 8 months ago (2010-10-22 01:14:58 UTC) #1
ken3
*** Submitted as http://code.google.com/p/go/source/detail?r=cbd356222779 *** bug right shifting 64 bits by a variable that equals ...
14 years, 8 months ago (2010-10-22 01:15:05 UTC) #2
rsc
14 years, 8 months ago (2010-10-22 02:21:15 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b