i didnt include any print tests because
8g cant execute it yet and you will
end up with different golden files.
On Sat, Mar 6, 2010 at 1:00 PM, <r@golang.org> wrote:
> Reviewers: rsc, yuri.vashchenko_gmail.com,
>
> Message:
> Hello rsc, ken (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> fix bug in complex printing: imaginary didn't have same format as real.
> add tests.
>
> Please review this at http://codereview.appspot.com/261041/show
>
> Affected files:
> M src/pkg/fmt/fmt_test.go
> M src/pkg/fmt/format.go
> M src/pkg/fmt/print.go
>
>
>
OK. I'll comment out the tests for now, but the fixes are still valuable.
-rob
On Mar 6, 2010, at 1:09 PM, Ken Thompson wrote:
> i didnt include any print tests because
> 8g cant execute it yet and you will
> end up with different golden files.
>
> On Sat, Mar 6, 2010 at 1:00 PM, <r@golang.org> wrote:
>> Reviewers: rsc, yuri.vashchenko_gmail.com,
>>
>> Message:
>> Hello rsc, ken (cc: golang-dev@googlegroups.com),
>>
>> I'd like you to review this change.
>>
>>
>> Description:
>> fix bug in complex printing: imaginary didn't have same format as real.
>> add tests.
>>
>> Please review this at http://codereview.appspot.com/261041/show
>>
>> Affected files:
>> M src/pkg/fmt/fmt_test.go
>> M src/pkg/fmt/format.go
>> M src/pkg/fmt/print.go
>>
>>
>>
Issue 261041: code review 261041: fix bug in complex printing: imaginary didn't have same...
(Closed)
Created 15 years ago by r
Modified 15 years ago
Reviewers:
Base URL:
Comments: 0