code review 2598041: os: correct Stat S_ISDIR on Windows

Windows: os.Stat do misjudge whether is a directory. and also whether is a readonly file.
This fix make 'goinstall' working on windows msys environment.
(without msys, you need http://gist.github.com/635886)

Fix Issue: http://code.google.com/p/go/issues/detail?id=960

[mattn, 2010-10-20 06:27:58]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
math-nuts@swtch.com),

I'd like you to review this change.

[mattn, 2010-10-20 06:30:54]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
math-nuts@swtch.com),

Please take another look.

[rsc, 2010-10-20 15:17:53]

This seems fine.  Please drop the unnecessary ( ).

Russ

[rsc1, 2010-10-20 15:45:29]

You followed the directions quite literally.
There's no need to cc math-nuts@swtch.com.

Also, please change the description (hg change)
to say:

os: correct Stat S_ISDIR on Windows
Fixes issue 960.

The syntax of the last line is important.

[brainman, 2010-10-20 23:26:08]

LGTM. Thanks for fixing my bug.

I will remove "Fixes issue 960" from change description, because, I believe,
there are other issues with goinstall on Windows to be resolved.

Also, I suggest you propose to install gomake.bat into $GOBIN on windows as per
your reference http://gist.github.com/635886. I'm not saying it is right way to
go, but would bring out everyone's opinion in the clear. We might also discuss
what goinstall should do if there is no make and others installed on user system
too.

Alex

[brainman, 2010-10-20 23:29:52]

*** Submitted as http://code.google.com/p/go/source/detail?r=fbf8685296f4 ***

os: correct Stat S_ISDIR on Windows

R=rsc, brainman
CC=golang-dev
http://codereview.appspot.com/2598041

Committer: Alex Brainman <alex.brainman@gmail.com>

[mattn, 2010-10-20 23:52:59]

Sorry.

ok, Can I change description without changing issue number?

On 2010/10/20 15:45:29, rsc1 wrote:
> You followed the directions quite literally.
> There's no need to cc mailto:math-nuts@swtch.com.
> 
> Also, please change the description (hg change)
> to say:
> 
> os: correct Stat S_ISDIR on Windows
> Fixes issue 960.
> 
> The syntax of the last line is important.

ok, I'll be carefully.

Thanks.

[brainman, 2010-10-21 00:13:19]

> .. Can I change description without changing issue number?
> 

Yes. "hg change 2598041" would bring a form, where you could change any field
for that change: description, add reviewers, add or remove files.

[mattn, 2010-10-21 00:25:32]

> Also, I suggest you propose to install gomake.bat into $GOBIN on windows as
per
> your reference http://gist.github.com/635886. I'm not saying it is right way
to
> go, but would bring out everyone's opinion in the clear. We might also discuss
> what goinstall should do if there is no make and others installed on user
system
> too.

ok, I agree.