Issue 2556041: code review 2556041: runtime: fix amd64 build (broke by 386 support for Plan 9)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2556041: code review 2556041: runtime: fix amd64 build (broke by 386 support for Plan 9) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by rsc

Modified:
14 years, 9 months ago

Reviewers:
r2

CC:
r, golang-dev

Visibility:
Public.

Description

runtime: fix amd64 build (broke by 386 support for Plan 9)

Patch Set 1 #

Patch Set 2 : code review 2556041: runtime: fix amd64 build (broke by 386 support for Plan 9) #

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	src/pkg/runtime/386/asm.s	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	src/pkg/runtime/runtime.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 9 months ago (2010-10-18 17:01:08 UTC) #1

rsc

*** Submitted as d0b988290591 *** runtime: fix amd64 build (broke by 386 support for Plan ...

14 years, 9 months ago (2010-10-18 17:01:21 UTC) #2

14 years, 9 months ago (2010-10-18 18:01:14 UTC) #3

LGTM

On Oct 18, 2010, at 10:01 AM, rsc@golang.org wrote:

> Reviewers: r,
> 
> Message:
> Hello r (cc: golang-dev@googlegroups.com),
> 
> I'd like you to review this change.
> 
> 
> Description:
> runtime: fix amd64 build (broke by 386 support for Plan 9)
> 
> Please review this at http://codereview.appspot.com/2556041/
> 
> Affected files:
>  M src/pkg/runtime/386/asm.s
>  M src/pkg/runtime/runtime.c
> 
> 
> Index: src/pkg/runtime/386/asm.s
> ===================================================================
> --- a/src/pkg/runtime/386/asm.s
> +++ b/src/pkg/runtime/386/asm.s
> @@ -416,4 +416,3 @@
> GLOBL g0(SB), $1024
> GLOBL tls0(SB), $32
> GLOBL initcgo(SB), $4
> -GLOBL isplan9(SB), $4
> Index: src/pkg/runtime/runtime.c
> ===================================================================
> --- a/src/pkg/runtime/runtime.c
> +++ b/src/pkg/runtime/runtime.c
> @@ -147,7 +147,7 @@
> 	argv = v;
> }
> 
> -extern int32 isplan9;
> +int32 isplan9;
> 
> void
> goargs(void)
> 
>

Expand All Messages | Collapse All Messages