Issue 2550041: code review 2550041: gc: update usage string in doc.go

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2550041: code review 2550041: gc: update usage string in doc.go (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by adg

Modified:
14 years, 8 months ago

Reviewers:

CC:
rsc, r2, r, golang-dev

Visibility:
Public.

Patch Set 2 : code review 2550041: gc: update usage string in doc.go #

Total comments: 1

Patch Set 3 : code review 2550041: gc: update usage string in doc.go #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	src/cmd/gc/doc.go	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

adg

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 8 months ago (2010-10-18 01:04:38 UTC) #1

I think making "file ..." the subject of an English phrase is odd. How about ...

14 years, 8 months ago (2010-10-18 01:19:35 UTC) #2

adg

Hello rsc, r2 (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 8 months ago (2010-10-18 02:09:09 UTC) #3

LGTM http://codereview.appspot.com/2550041/diff/4001/src/cmd/gc/doc.go File src/cmd/gc/doc.go (right): http://codereview.appspot.com/2550041/diff/4001/src/cmd/gc/doc.go#newcode30 src/cmd/gc/doc.go:30: The specified files must be Go source files ...

14 years, 8 months ago (2010-10-18 19:54:19 UTC) #4

adg

14 years, 8 months ago (2010-10-18 22:26:17 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=3fa318b23f13 ***

gc: update usage string in doc.go

R=rsc, r2, r
CC=golang-dev
http://codereview.appspot.com/2550041

Expand All Messages | Collapse All Messages