Issue 254043: code review 254043: PTAL

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 254043: code review 254043: PTAL (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by ken3

Modified:
15 years, 5 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

PTAL

Patch Set 1 #

Patch Set 2 : code review 254043: PTAL #

Patch Set 3 : code review 254043: PTAL #

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -65 lines)			Patch
	M	src/pkg/fmt/format.go	View	1 2	1 chunk	+54 lines, -0 lines	0 comments	Download
	M	src/pkg/fmt/print.go	View		7 chunks	+26 lines, -65 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ken3

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 5 months ago (2010-03-06 19:26:24 UTC) #1

ken3

*** Submitted as http://code.google.com/p/go/source/detail?r=7ce3e5e981b9 *** PTAL R=r CC=golang-dev http://codereview.appspot.com/254043

15 years, 5 months ago (2010-03-06 19:26:38 UTC) #2

15 years, 5 months ago (2010-03-06 19:39:04 UTC) #3

LGTM

On Mar 6, 2010, at 11:26 AM, ken@google.com wrote:

> Reviewers: r,
> 
> Message:
> Hello r (cc: golang-dev@googlegroups.com),
> 
> I'd like you to review this change.
> 
> 
> Description:
> PTAL
> 
> Please review this at http://codereview.appspot.com/254043/show
> 
> Affected files:
>  M src/pkg/fmt/format.go
>  M src/pkg/fmt/print.go
> 
>

Expand All Messages | Collapse All Messages