Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 2540041: code review 2540041: Export changes from Google-internal version: (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by dsymonds
Modified:
14 years, 10 months ago
Reviewers:
CC:
r, golang-dev
Visibility:
Public.

Description

Export changes from Google-internal version: - faster text parsing - use numbers instead of repeated Xs for package import name conflict resolution

Patch Set 1 #

Patch Set 2 : code review 2540041: Export changes from Google-internal version: #

Patch Set 3 : code review 2540041: Export changes from Google-internal version: #

Patch Set 4 : code review 2540041: Export changes from Google-internal version: #

Patch Set 5 : code review 2540041: Export changes from Google-internal version: #

Patch Set 6 : code review 2540041: Export changes from Google-internal version: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -17 lines) Patch
M compiler/generator/generator.go View 2 chunks +3 lines, -2 lines 0 comments Download
M proto/properties.go View 3 chunks +7 lines, -4 lines 0 comments Download
M proto/text_parser.go View 2 chunks +11 lines, -11 lines 0 comments Download
M proto/text_parser_test.go View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 3
dsymonds
Hello r@golang.org (cc: golang-dev, golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 10 months ago (2010-10-16 00:15:08 UTC) #1
r
LGTM
14 years, 10 months ago (2010-10-16 00:25:48 UTC) #2
dsymonds
14 years, 10 months ago (2010-10-16 00:33:26 UTC) #3
*** Submitted as 15e1ad1f1315 ***

		Export changes from Google-internal version:
	          - faster text parsing
                  - use numbers instead of repeated Xs for package import name
conflict resolution

R=r
CC=golang-dev
http://codereview.appspot.com/2540041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b