Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(47)

Issue 2533041: code review 2533041: 6l, 8l: avoid recursion in asmandsz (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 8 months ago by rsc
Modified:
14 years, 8 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

6l, 8l: avoid recursion in asmandsz The old code said if(x) { handle a return } aa = *a rewrite aa to make x true recursivecall(&aa) The new code says params = copy out of a if(!x) { rewrite params to make x true } handle params but it's hard to see that in the Rietveld diffs because it gets confused by changes in indentation. Avoiding the recursion makes other changes easier.

Patch Set 1 #

Patch Set 2 : code review 2533041: 6l, 8l: avoid recursion in asmandsz #

Patch Set 3 : code review 2533041: 6l, 8l: avoid recursion in asmandsz #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -191 lines) Patch
M src/cmd/6l/span.c View 5 chunks +94 lines, -99 lines 0 comments Download
M src/cmd/8l/span.c View 5 chunks +88 lines, -92 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 8 months ago (2010-10-15 17:01:01 UTC) #1
rsc
*** Submitted as 43603498d39b *** 6l, 8l: avoid recursion in asmandsz The old code said ...
14 years, 8 months ago (2010-10-15 17:01:10 UTC) #2
ken3
14 years, 8 months ago (2010-10-15 19:41:04 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b