Issue 252041: code review 252041: big: fix mistakes with probablyPrime

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 252041: code review 252041: big: fix mistakes with probablyPrime (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by agl1

Modified:
15 years, 5 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

big: fix mistakes with probablyPrime probablyPrime would return false negatives in some cases. This code has now been tested against GMP for several million iterations without issues. Fixes issue 638.

Patch Set 1 #

Patch Set 2 : code review 252041: big: fix mistakes with probablyPrime #

Patch Set 3 : code review 252041: big: fix mistakes with probablyPrime #

Patch Set 4 : code review 252041: big: fix mistakes with probablyPrime #

Patch Set 5 : code review 252041: big: fix mistakes with probablyPrime #

Patch Set 6 : code review 252041: big: fix mistakes with probablyPrime #

Patch Set 7 : code review 252041: big: fix mistakes with probablyPrime #

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -4 lines)			Patch
	M	src/pkg/big/int_test.go	View		2 chunks	+5 lines, -2 lines	0 comments	Download
	M	src/pkg/big/nat.go	View		4 chunks	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

agl1

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 5 months ago (2010-03-05 20:00:46 UTC) #3

aam

thanks! i was stuck in the same code trying ot figure it out today. here's ...

15 years, 5 months ago (2010-03-05 20:03:42 UTC) #4

agl1

15 years, 5 months ago (2010-03-05 20:55:31 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=19816b24c32c ***

big: fix mistakes with probablyPrime

probablyPrime would return false negatives in some cases.

This code has now been tested against GMP for several million iterations without
issues.

Fixes issue 638.

R=rsc
CC=golang-dev
http://codereview.appspot.com/252041

Expand All Messages | Collapse All Messages