Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9143)

Issue 2520041: Build: another hack for translations (fix 1323). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by Graham Percival (old account)
Modified:
13 years, 6 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Build: another hack for translations (fix 1323).

Patch Set 1 #

Total comments: 1

Patch Set 2 : Another version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M python/auxiliar/postprocess_html.py View 1 1 chunk +18 lines, -6 lines 0 comments Download

Messages

Total messages: 6
Graham Percival (old account)
13 years, 6 months ago (2010-10-14 20:16:01 UTC) #1
John Mandereau
Besides the niptick, it looks good to me. I tested by building both offline and ...
13 years, 6 months ago (2010-10-17 16:52:03 UTC) #2
Graham Percival (old account)
On 2010/10/17 16:52:03, John Mandereau wrote: > python/auxiliar/postprocess_html.py:357: extra_depth = '../' > '../' is is ...
13 years, 6 months ago (2010-10-17 18:28:50 UTC) #3
Graham Percival (old account)
Here's another version. Note that the "extra depth" thing is now added to the *non*-translated ...
13 years, 6 months ago (2010-10-17 21:14:11 UTC) #4
John Mandereau
On 2010/10/17 21:14:11, Graham Percival wrote: > Here's another version. Note that the "extra depth" ...
13 years, 6 months ago (2010-10-17 22:40:05 UTC) #5
Graham Percival
13 years, 6 months ago (2010-10-17 22:45:25 UTC) #6
On Sun, Oct 17, 2010 at 10:40:05PM +0000, john.mandereau@gmail.com wrote:
> On 2010/10/17 21:14:11, Graham Percival wrote:
> >Along the way, I've found that firefox is profoundly unhappy with
> "..//..".
> >That may have prompted me to add the extra ../ to translations
> initially.  Or
> >maybe there's still something that's messed up.
> 
> This new patch isn't good, not because of the double-slash, but because
> it breaks offline docs "Back to..." link.

Eh?  The patch only does stuff for the online target.  That's what
line 349 is supposed to do:
            if target == 'online':

If the patch breaks offline docs, then something is /really/
messed up.  Did my 819365f311a832c5cc57f086016069efdbee91fa break
the offline docs?

Cheers,
- Graham
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b