Issue 2519042: code review 2519042: gc: keep track of real actual type of identifiers.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2519042: code review 2519042: gc: keep track of real actual type of identifiers. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by lvd

Modified:
14 years, 8 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

gc: keep track of real actual type of identifiers.

Patch Set 2 : code review 2519042: gc: keep track of real actual type of identifiers. #

Patch Set 3 : code review 2519042: gc: keep track of real actual type of identifiers. #

Total comments: 3

Patch Set 4 : code review 2519042: gc: keep track of real actual type of identifiers. #

Patch Set 5 : code review 2519042: gc: keep track of real actual type of identifiers. #

Patch Set 6 : code review 2519042: gc: keep track of real actual type of identifiers. #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -13 lines)			Patch
M	src/cmd/gc/go.h	View	1	4 chunks	+7 lines, -6 lines	0 comments	Download
M	src/cmd/gc/subr.c	View	1 2 3 4	3 chunks	+6 lines, -6 lines	0 comments	Download
M	src/cmd/gc/typecheck.c	View	1	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

lvd

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 8 months ago (2010-10-15 19:07:22 UTC) #1

rsc1

http://codereview.appspot.com/2519042/diff/5001/src/cmd/gc/go.h File src/cmd/gc/go.h (right): http://codereview.appspot.com/2519042/diff/5001/src/cmd/gc/go.h#newcode640 src/cmd/gc/go.h:640: * uchar array[8]; // pointer to data These changes ...

14 years, 8 months ago (2010-10-15 19:11:10 UTC) #2

lvd

now it should be ok. On Fri, Oct 15, 2010 at 21:11, <rsc@google.com> wrote: > ...

14 years, 8 months ago (2010-10-15 19:22:31 UTC) #3

lvd

14 years, 8 months ago (2010-10-15 19:25:40 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=a4c45cf3b7b5 ***

gc: keep track of real actual type of identifiers.

R=rsc
CC=golang-dev
http://codereview.appspot.com/2519042

Expand All Messages | Collapse All Messages