Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1430)

Issue 2519041: code review 2519041: logging: update code to new logging API (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by r
Modified:
14 years, 10 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

logging: update code to new logging API

Patch Set 1 #

Patch Set 2 : code review 2519041: logging: update code to new logging API #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M compiler/generator/generator.go View 4 chunks +4 lines, -4 lines 0 comments Download
M proto/lib.go View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3
r
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 10 months ago (2010-10-14 19:50:16 UTC) #1
rsc
LGTM
14 years, 10 months ago (2010-10-14 19:54:01 UTC) #2
r
14 years, 10 months ago (2010-10-14 20:02:22 UTC) #3
*** Submitted as
http://code.google.com/p/goprotobuf/source/detail?r=34b73894c9c7 ***

logging: update code to new logging API

R=rsc
CC=golang-dev
http://codereview.appspot.com/2519041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b