Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.
LGTM should there be a TODO? On Oct 14, 2010, at 10:11 AM, rsc@golang.org wrote: > Reviewers: r, > > Message: > Hello r (cc: golang-dev@googlegroups.com), > > I'd like you to review this change. > > > Description: > syscall: fix arm networking > > Suggested by fango (fan.howard@gmail.com) > > > Please review this at http://codereview.appspot.com/2514041/ > > Affected files: > M src/pkg/syscall/ztypes_linux_arm.go > > > Index: src/pkg/syscall/ztypes_linux_arm.go > =================================================================== > --- a/src/pkg/syscall/ztypes_linux_arm.go > +++ b/src/pkg/syscall/ztypes_linux_arm.go > @@ -2,9 +2,10 @@ > > // MACHINE GENERATED - DO NOT EDIT. > > -// Manual corrections: UGH > +// Manual corrections: UGH - need to fix godefs > // remove duplicate PtraceRegs type > // change RawSockaddrUnix field to Path [108]int8 (was uint8() > +// add padding to EpollEvent > > package syscall > > @@ -290,6 +291,7 @@ > > type EpollEvent struct { > Events uint32 > + PadFd int32 > Fd int32 > Pad int32 > } > >
*** Submitted as 83e85c78118d *** syscall: fix arm networking Suggested by fango (fan.howard@gmail.com) R=r, r2 CC=golang-dev http://codereview.appspot.com/2514041