Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(73)

Issue 2512041: code review 2512041: 5l, 6l, 8l: accumulate data image during import (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 7 months ago by rsc
Modified:
14 years, 7 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

5l, 6l, 8l: accumulate data image during import Using explicit relocations internally, we can represent the data for a particular symbol as an initialized block of memory instead of a linked list of ADATA instructions. The real goal here is to be able to hand off some of the relocations to the dynamic linker when interacting with system libraries, but a pleasant side effect is that the memory image is much more compact than the ADATA list, so the linkers use less memory.

Patch Set 1 #

Patch Set 2 : code review 2512041: 5l, 6l, 8l: accumulate data image during import #

Patch Set 3 : code review 2512041: 5l, 6l, 8l: accumulate data image during import #

Patch Set 4 : code review 2512041: 5l, 6l, 8l: accumulate data image during import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1134 lines, -2474 lines) Patch
M src/cmd/5l/Makefile View 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/5l/asm.c View 1 16 chunks +51 lines, -378 lines 0 comments Download
M src/cmd/5l/l.h View 1 12 chunks +28 lines, -15 lines 0 comments Download
M src/cmd/5l/list.c View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/5l/noop.c View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/5l/obj.c View 1 11 chunks +32 lines, -67 lines 0 comments Download
M src/cmd/5l/pass.c View 1 2 chunks +0 lines, -339 lines 0 comments Download
M src/cmd/5l/span.c View 1 7 chunks +91 lines, -58 lines 0 comments Download
M src/cmd/5l/symtab.c View 1 2 3 2 chunks +8 lines, -15 lines 0 comments Download
M src/cmd/5l/thumb.c View 4 chunks +4 lines, -5 lines 0 comments Download
M src/cmd/6l/Makefile View 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/6l/asm.c View 1 11 chunks +16 lines, -480 lines 0 comments Download
M src/cmd/6l/l.h View 1 2 3 11 chunks +25 lines, -22 lines 0 comments Download
M src/cmd/6l/obj.c View 7 chunks +17 lines, -54 lines 0 comments Download
M src/cmd/6l/pass.c View 1 3 chunks +0 lines, -207 lines 0 comments Download
M src/cmd/6l/span.c View 1 8 chunks +44 lines, -44 lines 0 comments Download
M src/cmd/6l/symtab.c View 1 1 chunk +2 lines, -13 lines 0 comments Download
M src/cmd/8l/Makefile View 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/8l/asm.c View 1 2 3 15 chunks +31 lines, -381 lines 0 comments Download
M src/cmd/8l/l.h View 1 9 chunks +25 lines, -20 lines 0 comments Download
M src/cmd/8l/obj.c View 7 chunks +17 lines, -53 lines 0 comments Download
M src/cmd/8l/pass.c View 1 4 chunks +1 line, -188 lines 0 comments Download
M src/cmd/8l/span.c View 1 8 chunks +51 lines, -63 lines 0 comments Download
M src/cmd/8l/symtab.c View 1 1 chunk +2 lines, -7 lines 0 comments Download
A src/cmd/ld/data.c View 1 chunk +641 lines, -0 lines 0 comments Download
M src/cmd/ld/go.c View 3 chunks +4 lines, -47 lines 0 comments Download
M src/cmd/ld/lib.h View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download
M src/cmd/ld/lib.c View 3 chunks +11 lines, -3 lines 0 comments Download
M src/cmd/ld/macho.c View 4 chunks +10 lines, -10 lines 0 comments Download
M src/cmd/ld/pe.c View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 7 months ago (2010-10-15 03:48:37 UTC) #1
rsc
*** Submitted as 70ed048caad2 *** 5l, 6l, 8l: accumulate data image during import Using explicit ...
14 years, 7 months ago (2010-10-15 03:48:51 UTC) #2
ken3
14 years, 7 months ago (2010-10-20 23:04:51 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b