Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14265)

Issue 2505041: vertical spacing: Rename dimensions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by Mark Polesky
Modified:
13 years, 6 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

vertical spacing: Rename dimensions.

Patch Set 1 #

Patch Set 2 : vertical spacing: Update convert-ly. #

Patch Set 3 : vertical spacing: Convert affected regtests. #

Patch Set 4 : vertical spacing: Revise/rename affected regtests. #

Patch Set 5 : vertical spacing: Convert affected docs. #

Patch Set 6 : Doc: Vertical spacing nitpicks. #

Patch Set 7 : All 6 commits in one patch set. #

Patch Set 8 : Doc: Clarify vertical spacing naming format. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+311 lines, -284 lines) Patch
M Documentation/de/notation/spacing.itely View 8 chunks +35 lines, -35 lines 0 comments Download
M Documentation/es/notation/spacing.itely View 9 chunks +34 lines, -34 lines 0 comments Download
M Documentation/fr/notation/spacing.itely View 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/notation/spacing.itely View 5 6 7 7 chunks +56 lines, -43 lines 0 comments Download
A input/regression/page-breaking-markup-padding.ly View 4 1 chunk +18 lines, -0 lines 0 comments Download
A input/regression/page-breaking-markup-padding2.ly View 4 1 chunk +18 lines, -0 lines 0 comments Download
A input/regression/page-breaking-markup-padding3.ly View 4 1 chunk +21 lines, -0 lines 0 comments Download
M input/regression/page-breaking-min-distance.ly View 2 chunks +2 lines, -2 lines 0 comments Download
D input/regression/page-breaking-title-padding.ly View 3 1 chunk +0 lines, -18 lines 0 comments Download
D input/regression/page-breaking-title-padding2.ly View 3 1 chunk +0 lines, -18 lines 0 comments Download
D input/regression/page-breaking-title-padding3.ly View 3 1 chunk +0 lines, -21 lines 0 comments Download
M input/regression/page-spacing-loose-lines-between.ly View 3 4 1 chunk +6 lines, -5 lines 0 comments Download
M input/regression/page-spacing-loose-lines-header-padding.ly View 3 4 3 chunks +3 lines, -3 lines 0 comments Download
A input/regression/page-spacing-top-markup-spacing.ly View 1 chunk +20 lines, -0 lines 0 comments Download
M input/regression/page-spacing-top-system-spacing.ly View 3 4 2 chunks +2 lines, -2 lines 0 comments Download
D input/regression/page-spacing-top-title-spacing.ly View 3 4 1 chunk +0 lines, -19 lines 0 comments Download
M input/regression/paper-nested-override.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/stem-length-estimation.ly View 3 4 2 chunks +4 lines, -5 lines 0 comments Download
M input/regression/system-overstrike.ly View 3 4 2 chunks +4 lines, -3 lines 0 comments Download
M lily/constrained-breaking.cc View 3 chunks +27 lines, -27 lines 0 comments Download
M lily/include/constrained-breaking.hh View 1 chunk +7 lines, -7 lines 0 comments Download
M lily/page-breaking.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/page-layout-problem.cc View 6 chunks +22 lines, -22 lines 0 comments Download
M ly/paper-defaults-init.ly View 1 chunk +7 lines, -7 lines 0 comments Download
M python/convertrules.py View 1 chunk +13 lines, -1 line 0 comments Download
M scm/page.scm View 1 chunk +1 line, -1 line 0 comments Download
M scm/paper-system.scm View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4
Mark Polesky
Sorry this took so long. I uploaded all 6 commits as separate patch sets so ...
13 years, 6 months ago (2010-10-14 06:53:45 UTC) #1
Mark Polesky
Would anyone like to look over this or shall I just push it? It compiles ...
13 years, 6 months ago (2010-10-16 16:00:27 UTC) #2
Trevor Daniels
Looks ok to me, although I haven't tried committing it. Let's push it and move ...
13 years, 6 months ago (2010-10-16 20:38:22 UTC) #3
Graham Percival (old account)
13 years, 6 months ago (2010-10-17 17:20:31 UTC) #4
LGTM, and compiles cleanly from scratch.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b